Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Commit

Permalink
CI: Add maligned linter
Browse files Browse the repository at this point in the history
Run the `maligned` linter to minimise struct space.

Includes the single fix required to pass the `maligned` tests.

Fixes #1064.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
  • Loading branch information
jodh-intel committed Mar 14, 2018
1 parent 6cfbe2f commit bc256ef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .ci/go-static-checks.sh
Expand Up @@ -74,6 +74,7 @@ install_package github.com/opennota/check/cmd/varcheck
install_package honnef.co/go/tools/cmd/unused
install_package honnef.co/go/tools/cmd/staticcheck
install_package github.com/mdempsky/unconvert
install_package github.com/mdempsky/maligned

echo Doing go static checks on packages: $go_packages

Expand Down Expand Up @@ -106,7 +107,7 @@ for p in $go_packages; do golint -set_exit_status $p; done
echo "Running ineffassign..."
go list -f '{{.Dir}}' $go_packages | xargs -L 1 ineffassign

for tool in structcheck varcheck unused staticcheck unconvert
for tool in structcheck varcheck unused staticcheck unconvert maligned
do
echo "Running ${tool}..."
eval "$tool" "$go_packages"
Expand Down
2 changes: 1 addition & 1 deletion exec.go
Expand Up @@ -34,9 +34,9 @@ type execParams struct {
pidFile string
console string
consoleSock string
detach bool
processLabel string
noSubreaper bool
detach bool
}

var execCLICommand = cli.Command{
Expand Down

0 comments on commit bc256ef

Please sign in to comment.