Fix negative currentStep for small changes in position #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this library to drive an automotive gauge. Sometimes currentStep seems to ty to become negative (underflow), and the motor blocks until currentStep again enters the domain of valid step positions.
Simple test below.
During the test, the velocity variable
vel
is increased very quickly, so the destination step is reached but velocity did not ramp down quickly enough. This leads to theif (currentStep==targetStep && vel==0)
-condition not triggering, which in turn leads todir
being -1 whencurrentStep
reaches 0, inside thestepTo
function.Therefore it is better to limit
vel
to thedelta
to the target position.