Integrate PTNG with FiltaQuila for automatic printing

[cleidigh]

Work with @realraven to have messaging between FQ and PTNG
enabling automatic printing

@cleidigh

[RealRaven2000]

If you would like me to integration test later, can you either commit your current changes, make a new branch or upload a version here in a comment?

[RealRaven2000]

@cleidigh Some patch code - WIP!

printing_tools_patch_fq.zip

Currently the notification is not received by the listener in messengerOL.js (I tried adding notifyTools.enable() but no joy). Maybe @jobisoft can have a look!

Latest version of filtaquilla:
filtaquilla-3.3.1pre22.zip

• PrintingTools NG needs to be enabled in FQ settings dialog
• use "Print" as the filter action

[RealRaven2000]

@cleidigh
I did some more tests today - created a background page (one of the differences I have in my add-ons that we have a page for the background and include the script there, there was some fundamental difference here that was explained too many weeks ago on the Dev Call. Then I also added the "notifications" permission to the manifest. I also refreshed both WindowListener and Notifications APIs to the latest versions (notifications was only 1.1 and is currently 1.3). Still the same problem - the event listener in messengerOL.js still does not receive the message.

I also commented out unnecessary documents from registering the WindowListener in background.js (messenger.xul, msgPrintEngine.xhtml, msgPrintEngine.xul, addressbook.xul) to avoid any errors on startup.

changed files:
pntng-2.0.7p14.zip

[cleidigh]

i posted a first test
i get multiple handle events on the exp side

[RealRaven2000]

could you commit your changes?

[RealRaven2000]

here are the latest changes from todays zoom conference

content-new.zip

[cleidigh]

@RealRaven2000
@madvinegar
@querixg
@ditchfinder
@kiki-ja

All Axel and I have made a formal integration between FiltaQuila and PTNG

first you need the beta fq and ptng b14
https://github.com/cleidigh/printing-tools-ng/files/8091829/filtaquilla-3.3.1pre22.zip

on then enable ptng print in fq actions
create your filter with the print action
the message will print silently automatically

please post here with issues

thanks
@RealRaven2000
@cleidigh

All

[ditchfinder]

@RealRaven2000
@madvinegar
@querixg
@ditchfinder
@kiki-ja

Windows 10
FQ 3.3.1pre22 (installed zip file)
PTNG 2.0.7-b14p1 (Installed .xpi)
TB 91.6.1

Unable to get this to work still I'm afraid.

Used PTNG option ticked in FQ
Set up a new filter in case that was affecting anything.
Filter completes and logs show print action

CTRL + P uses PTNG options correctly

Tried a OS reboot and reinstall of add-ons but no change.

Only weird thing to note was that after reboot of OS both add-ons ahad already been removed from TB but not by me manually. Is there a setting in TB which automatically does this?

Cheers
Martin

[RealRaven2000]

Unable to get this to work still I'm afraid.

Used PTNG option ticked in FQ Set up a new filter in case that was affecting anything. Filter completes and logs show print action

When we successfully tested on my machine the other day I was definitely using 3.3.1 pre 22 - so it should be ok from that said. Did you install by dragging into extension manager or via "Debug ADd-ons"? The later would explain why they were removed on restart. Just drag the xpi / zip file into Extension manager and it should work. I believe @cleidigh added some logs to JavaScript error console, so you could check what's added there during filtering (Ctrl+Shift+J to open it)

[ditchfinder]

I Installed by clicking on the cog in the Add-ons manager and "Install Add-on from File"

I'll try again using the drag and drop approach and then look at the JS debugger

[kiki-ja]

@cleidigh
@RealRaven2000
@madvinegar
@querixg
@ditchfinder
All

FiltaQuilla 3.3.1pre22
PrintingTools NG 2.0.7-b14 (not -b14p1)
Thunderbird 91.6.1 64bit
Windows 10 Pro 21H2 64bit

The following is a report on the results of the automatic printing.
The result is that only one of the seven messages was printed.
I think it's probably the same as @ditchfinder.

Steps to Reproduce

1. Set "Use PrintingTools NG for printing" as Filter Action in FiltaQuilla.
2. In Filter Rules, set the Match Condition to Subject = "会議" and Action to Print.
3. Manually Run was executed on the target folder.
4. Only one of the seven messages whose subject matched "会議" was printed automatically.
5. The Filter Log shows the record of the automatic printing of the seven messages.

Please refer to the screenshot below.

@kiki-ja

[ditchfinder]

OK no change so using the debugger I can see:
Object { command: "printMessage", messageHeader: {…} }
background.js:159:10
but no output to printer

Other things to note.
Inorder for 'Print to be an option in Filters I have to tick both the Print and PTNG boxes in FQ

[RealRaven2000]

OK no change so using the debugger I can see: Object { command: "printMessage", messageHeader: {…} } background.js:159:10 but no output to printer

Other things to note. Inorder for 'Print to be an option in Filters I have to tick both the Print and PTNG boxes in FQ

Yes that's by design. About duplication: The problem is that Thunderbird has a hard time removing actions (unless you restart Thunderbird). And then it will only work if you have the [x] Print options switched on (this makes the Print command visible as action). the other checkbox "use Printing tools NG for printing" is just an additional option. To make that more obvious I should probably disable the option if the [x] Print option is disabled.

Since Tb messes up the removal of old actions, the topmost menu items may still trigger old code, so its probably best to restart Tb after installing a new version of FiltaQuilla.