Enable to build on systems lacking execinfo.h #7076
Conversation
|
I think it's better to use: |
|
@jonaski Thanks, I'll try that. |
|
@jonaski is that enough? |
| #include <QtGlobal> | ||
| #ifdef Q_OS_UNIX | ||
| #ifdef HAVE_BACKTRACE | ||
| #include <execinfo.h> |
There was a problem hiding this comment.
execinfo.h also may not be correct. FindBacktrace recommends generating a file that includes ${Backtrace_HEADER}
https://cmake.org/cmake/help/v3.0/module/FindBacktrace.html
There was a problem hiding this comment.
Yes, that's why I was asking... I went for the trivial change...
The Q_OS_UNIX macro is inappropriate because many UNIX-like platforms may lack backtrace support in the libc. E.g.: Darwin / Mac OS X, Musl libc, OpenBSD, OpenIndiana.
| ) | ||
|
|
||
| find_package(Backtrace) | ||
| configure_file(core/conf_backtrace.h.in conf_backtrace.h) |
There was a problem hiding this comment.
I think you should only do this if the package was found. Otherwise, Backtrace_HEADER won't be defined.
There was a problem hiding this comment.
what do you mean? the header file needs to be produced, always...
There was a problem hiding this comment.
also, the include is guarded by an ifdef...
There was a problem hiding this comment.
Oh yeah. I didn't notice that you had moved the ifdef.
4 participants
The Q_OS_UNIX macro is inappropriate for detection because many UNIX-like
platforms may lack backtrace support in the libc. E.g.: Darwin / Mac OS X,
Musl libc, OpenBSD, OpenIndiana.