New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

design update #54

Merged
merged 9 commits into from Nov 15, 2014

Conversation

Projects
None yet
4 participants
@markknol
Contributor

markknol commented Oct 20, 2014

Hi!

To improve try-haxe I created an update to prettify the application and make it more recognizable in style of haxe.org. Hope you like it 馃槃

  • added haxe styled header with logo and links to docs
  • add subline "the Haxe playground" because it sounds cool
  • fonts in line with haxe.org website
  • added example dropdown with 17 examples. I did this because I think people might want to play with Haxe somewhere before they even download it. This (should) gives them an first impression of some great features.
  • added disclaimer: The code you enter on Try-Haxe is compiled and saved on our servers.
  • added favicon
  • added about page with logo and download link
  • made haxe source editor higher; more space to code in!
  • renamed "link" button to "run standalone"
  • hide fullscreen button
  • added own FB-share image

The logo/images/favicon are hosted/linked from haxe.org, I assume they don't mind.
try-haxe-update

@nadako

This comment has been minimized.

Show comment
Hide comment
@nadako

nadako Oct 20, 2014

i think all these methods (including constructor) could be inlined to show how awesome object inlining is

i think all these methods (including constructor) could be inlined to show how awesome object inlining is

This comment has been minimized.

Show comment
Hide comment
@markknol

markknol Oct 20, 2014

Owner

Done. Thanks for reviewing!

Owner

markknol replied Oct 20, 2014

Done. Thanks for reviewing!

This comment has been minimized.

Show comment
Hide comment
@nadako

nadako Oct 20, 2014

Hm, I've just tried that and it seems not to be fully inlined for some reason.

Hm, I've just tried that and it seems not to be fully inlined for some reason.

This comment has been minimized.

Show comment
Hide comment
@nadako

nadako Oct 20, 2014

Ah, that's because you assign it to a var. If you do for (char in new MyStringIterator("haxe is great")) it will be fully inlined

Ah, that's because you assign it to a var. If you do for (char in new MyStringIterator("haxe is great")) it will be fully inlined

markknol added some commits Oct 20, 2014

@clemos

This comment has been minimized.

Show comment
Hide comment
@clemos

clemos Oct 21, 2014

Owner

Looks awesome, I'll deploy it ASAP, hopefully by the end of the week.
Thanks a lot !

Owner

clemos commented Oct 21, 2014

Looks awesome, I'll deploy it ASAP, hopefully by the end of the week.
Thanks a lot !

@markknol

This comment has been minimized.

Show comment
Hide comment
@markknol

markknol Oct 21, 2014

Contributor

Good to hear!! Looking forward to it 馃槂

Contributor

markknol commented Oct 21, 2014

Good to hear!! Looking forward to it 馃槂

@markknol

This comment has been minimized.

Show comment
Hide comment
@markknol

markknol Oct 23, 2014

Contributor

This should also close #44 since the editor is higher now.

Contributor

markknol commented Oct 23, 2014

This should also close #44 since the editor is higher now.

@profelis

This comment has been minimized.

Show comment
Hide comment
@profelis

profelis Oct 24, 2014

Contributor

Awesome! Thanks! great work

Contributor

profelis commented Oct 24, 2014

Awesome! Thanks! great work

@markknol

This comment has been minimized.

Show comment
Hide comment
@markknol

markknol Oct 30, 2014

Contributor

If you put this update live, please also consider upgrading the haxe version to the latest release version 3.1.3

Contributor

markknol commented Oct 30, 2014

If you put this update live, please also consider upgrading the haxe version to the latest release version 3.1.3

markknol added some commits Nov 2, 2014

Update style.css
* Small fix responsive design on small screen.
* CSS formatting
Update index.html
Links should open in _blank
Update index.html
Updated link to share image
Update index.html
fix extension of new share image
@profelis

This comment has been minimized.

Show comment
Hide comment
@profelis

profelis Nov 9, 2014

Contributor

up

Contributor

profelis commented Nov 9, 2014

up

@clemos

This comment has been minimized.

Show comment
Hide comment
@clemos

clemos Nov 12, 2014

Owner

hey, sorry I haven't had much time these days.
I'll try to push the update online by this week end.

Owner

clemos commented Nov 12, 2014

hey, sorry I haven't had much time these days.
I'll try to push the update online by this week end.

clemos added a commit that referenced this pull request Nov 15, 2014

@clemos clemos merged commit 26900e0 into clemos:master Nov 15, 2014

@clemos

This comment has been minimized.

Show comment
Hide comment
@clemos

clemos Nov 15, 2014

Owner

I've pushed your upgrade online :D
Thanks again for your contribution !
I've slightly changed the examples select to make it more "bootstrap standard".
Also, I've noticed a few issues with examples :

  • "Pattern matching" is the same as "Array Comprehension" ?
  • "Function binding" fails to compile
  • "Metadata" fails to run, likely due to #50

I'd be very grateful if you could fix these in a new PR ;)

Owner

clemos commented Nov 15, 2014

I've pushed your upgrade online :D
Thanks again for your contribution !
I've slightly changed the examples select to make it more "bootstrap standard".
Also, I've noticed a few issues with examples :

  • "Pattern matching" is the same as "Array Comprehension" ?
  • "Function binding" fails to compile
  • "Metadata" fails to run, likely due to #50

I'd be very grateful if you could fix these in a new PR ;)

@clemos

This comment has been minimized.

Show comment
Hide comment
@clemos

clemos Nov 15, 2014

Owner

PS: also, you can announce the update on the mailing-list if you want :)

Owner

clemos commented Nov 15, 2014

PS: also, you can announce the update on the mailing-list if you want :)

@profelis

This comment has been minimized.

Show comment
Hide comment
Contributor

profelis commented Nov 15, 2014

@profelis

This comment has been minimized.

Show comment
Hide comment
@profelis

profelis Nov 15, 2014

Contributor

@clemos for "pattern matching" you can found examples here http://haxe.org/manual/lf-pattern-matching.html

Contributor

profelis commented Nov 15, 2014

@clemos for "pattern matching" you can found examples here http://haxe.org/manual/lf-pattern-matching.html

@clemos

This comment has been minimized.

Show comment
Hide comment
@clemos

clemos Nov 15, 2014

Owner

Sure, but maybe @markknol has some example of his own ;)

Owner

clemos commented Nov 15, 2014

Sure, but maybe @markknol has some example of his own ;)

@markknol

This comment has been minimized.

Show comment
Hide comment
@markknol

markknol Nov 15, 2014

Contributor

Ok I also saw some examples failing. ill look into this soon!

Thanks for updating haxe to 3.1.3 too!!

Contributor

markknol commented Nov 15, 2014

Ok I also saw some examples failing. ill look into this soon!

Thanks for updating haxe to 3.1.3 too!!

@markknol

This comment has been minimized.

Show comment
Hide comment
@markknol

markknol Nov 15, 2014

Contributor

Update: wait, its fixed :) long live opensource!

Contributor

markknol commented Nov 15, 2014

Update: wait, its fixed :) long live opensource!

@markknol markknol deleted the markknol:design-update branch Dec 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment