Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for API change #8

Merged
merged 9 commits into from Sep 21, 2019

Conversation

@dannynicolas
Copy link
Contributor

commented Sep 5, 2019

It looks like the dreamhost api changed a little bit of it was outputting for the list record.

This PR changes how it looks for the record and should now be functional again.

Feel free to make suggestions / comments.

This resolves #7

dannynicolas and others added 9 commits Sep 5, 2019
@clempaul

This comment has been minimized.

Copy link
Owner

commented Sep 21, 2019

Thanks for the contribution @dannynicolas! Sorry for the delay in looking at this.

The regex for the IP address wasn't quite correct (it would match something like 100.10.10.100, but not 100.100.100.100), and I've reduced the verbosity a bit so that it only outputs the current record if it's in verbose mode. I took the liberty of pushing these changes directly into your branch, I hope that's ok!

@clempaul clempaul merged commit e7a230f into clempaul:master Sep 21, 2019
@clempaul clempaul self-assigned this Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.