From 8deac8c784a82d7c1e557684250a98066edd3b84 Mon Sep 17 00:00:00 2001 From: Mark Pitsilos Date: Tue, 26 Mar 2024 15:09:05 +0200 Subject: [PATCH] fix(clerk-js): Rolling back support for sign_in.needs_new_password on password form --- .changeset/strange-zoos-tie.md | 5 ++++ .../SignIn/SignInFactorOnePasswordCard.tsx | 2 -- .../SignIn/__tests__/SignInFactorOne.test.tsx | 23 ------------------- 3 files changed, 5 insertions(+), 25 deletions(-) create mode 100644 .changeset/strange-zoos-tie.md diff --git a/.changeset/strange-zoos-tie.md b/.changeset/strange-zoos-tie.md new file mode 100644 index 00000000000..a1ff9dd2d0f --- /dev/null +++ b/.changeset/strange-zoos-tie.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +We are rolling back support for password complexity / strength checks during sign-in. Feature will be limited to HIBP for now. Hence, the password form need not expect a sign_in status of `needs_new_password`. diff --git a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOnePasswordCard.tsx b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOnePasswordCard.tsx index 358b90cc23e..9ec4c188fb8 100644 --- a/packages/clerk-js/src/ui/components/SignIn/SignInFactorOnePasswordCard.tsx +++ b/packages/clerk-js/src/ui/components/SignIn/SignInFactorOnePasswordCard.tsx @@ -71,8 +71,6 @@ export const SignInFactorOnePasswordCard = (props: SignInFactorOnePasswordProps) return setActive({ session: res.createdSessionId, beforeEmit: navigateAfterSignIn }); case 'needs_second_factor': return navigate('../factor-two'); - case 'needs_new_password': - return navigate('../reset-password'); default: return console.error(clerkInvalidFAPIResponse(res.status, supportEmail)); } diff --git a/packages/clerk-js/src/ui/components/SignIn/__tests__/SignInFactorOne.test.tsx b/packages/clerk-js/src/ui/components/SignIn/__tests__/SignInFactorOne.test.tsx index 9e8797fa67b..d511fc84bf1 100644 --- a/packages/clerk-js/src/ui/components/SignIn/__tests__/SignInFactorOne.test.tsx +++ b/packages/clerk-js/src/ui/components/SignIn/__tests__/SignInFactorOne.test.tsx @@ -227,29 +227,6 @@ describe('SignInFactorOne', () => { }); }); }); - - it('redirects to `reset-password` if signIn requires a new password', async () => { - const { wrapper, fixtures } = await createFixtures(f => { - f.withEmailAddress(); - f.withPassword(); - f.withPreferredSignInStrategy({ strategy: 'password' }); - f.startSignInWithPhoneNumber({ supportPassword: true }); - }); - fixtures.signIn.prepareFirstFactor.mockReturnValueOnce(Promise.resolve({} as SignInResource)); - - fixtures.signIn.attemptFirstFactor.mockReturnValueOnce( - Promise.resolve({ status: 'needs_new_password' } as SignInResource), - ); - - await runFakeTimers(async () => { - const { userEvent } = render(, { wrapper }); - await userEvent.type(screen.getByLabelText('Password'), '123456'); - await userEvent.click(screen.getByText('Continue')); - await waitFor(() => { - expect(fixtures.router.navigate).toHaveBeenCalledWith('../reset-password'); - }); - }); - }); }); describe('Forgot Password', () => {