From 998301cccb1ea7015523a855283da32527c3e102 Mon Sep 17 00:00:00 2001 From: panteliselef Date: Tue, 15 Oct 2024 22:46:54 +0300 Subject: [PATCH] chore(clerk-js,types): Drop `maxAgeMinutes` from `__experimental_startVerification` --- .changeset/fluffy-goats-protect.md | 7 +++++++ packages/clerk-js/src/core/resources/Session.ts | 2 -- packages/types/src/session.ts | 2 -- packages/types/src/sessionVerification.ts | 11 ++--------- 4 files changed, 9 insertions(+), 13 deletions(-) create mode 100644 .changeset/fluffy-goats-protect.md diff --git a/.changeset/fluffy-goats-protect.md b/.changeset/fluffy-goats-protect.md new file mode 100644 index 00000000000..8d3fb602ea5 --- /dev/null +++ b/.changeset/fluffy-goats-protect.md @@ -0,0 +1,7 @@ +--- +"@clerk/clerk-js": minor +"@clerk/types": minor +--- + +Drop `maxAgeMinutes` from `__experimental_startVerification`. +Drop types `__experimental_SessionVerificationConfig` and `__experimental_SessionVerificationMaxAgeMinutes`. diff --git a/packages/clerk-js/src/core/resources/Session.ts b/packages/clerk-js/src/core/resources/Session.ts index 9a1c3963af0..b9ef6743736 100644 --- a/packages/clerk-js/src/core/resources/Session.ts +++ b/packages/clerk-js/src/core/resources/Session.ts @@ -122,7 +122,6 @@ export class Session extends BaseResource implements SessionResource { __experimental_startVerification = async ({ level, - maxAgeMinutes, }: __experimental_SessionVerifyCreateParams): Promise<__experimental_SessionVerificationResource> => { const json = ( await BaseResource._fetch({ @@ -130,7 +129,6 @@ export class Session extends BaseResource implements SessionResource { path: `/client/sessions/${this.id}/verify`, body: { level, - maxAgeMinutes, } as any, }) )?.response as unknown as __experimental_SessionVerificationJSON; diff --git a/packages/types/src/session.ts b/packages/types/src/session.ts index b9f05337451..d401e563166 100644 --- a/packages/types/src/session.ts +++ b/packages/types/src/session.ts @@ -18,7 +18,6 @@ import type { ClerkResource } from './resource'; import type { __experimental_ReverificationConfig, __experimental_SessionVerificationLevel, - __experimental_SessionVerificationMaxAgeMinutes, __experimental_SessionVerificationResource, } from './sessionVerification'; import type { TokenResource } from './token'; @@ -155,7 +154,6 @@ export type GetToken = (options?: GetTokenOptions) => Promise; export type __experimental_SessionVerifyCreateParams = { level: __experimental_SessionVerificationLevel; - maxAgeMinutes: __experimental_SessionVerificationMaxAgeMinutes; }; export type __experimental_SessionVerifyPrepareFirstFactorParams = EmailCodeConfig | PhoneCodeConfig; diff --git a/packages/types/src/sessionVerification.ts b/packages/types/src/sessionVerification.ts index 8dbd46a3773..b5dbf4a771a 100644 --- a/packages/types/src/sessionVerification.ts +++ b/packages/types/src/sessionVerification.ts @@ -17,22 +17,15 @@ export type __experimental_SessionVerificationStatus = 'needs_first_factor' | 'n export type __experimental_SessionVerificationTypes = 'veryStrict' | 'strict' | 'moderate' | 'lax'; -export type __experimental_SessionVerificationConfig = - | __experimental_SessionVerificationTypes - | { - level: __experimental_SessionVerificationLevel; - maxAgeMinutes: __experimental_SessionVerificationMaxAgeMinutes; - }; - export type __experimental_ReverificationConfig = | __experimental_SessionVerificationTypes | { level: __experimental_SessionVerificationLevel; - afterMinutes: __experimental_SessionVerificationMaxAgeMinutes; + afterMinutes: __experimental_SessionVerificationAfterMinutes; }; export type __experimental_SessionVerificationLevel = 'firstFactor' | 'secondFactor' | 'multiFactor'; -export type __experimental_SessionVerificationMaxAgeMinutes = number; +export type __experimental_SessionVerificationAfterMinutes = number; export type __experimental_SessionVerificationFirstFactor = EmailCodeFactor | PhoneCodeFactor | PasswordFactor; export type __experimental_SessionVerificationSecondFactor = PhoneCodeFactor | TOTPFactor | BackupCodeFactor;