From 2c859131278460826fd14e1c97477fc7f0f260ce Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Wed, 23 Oct 2024 23:29:54 -0400 Subject: [PATCH 1/3] fix(clerk-js): Fix issue for legal consent checkbox showing up in when only social sign up is enabled --- packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx index 1d748d56c7e..7b66092fc0e 100644 --- a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx +++ b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx @@ -103,6 +103,7 @@ function _SignUpStart(): JSX.Element { const hasTicket = !!formState.ticket.value; const hasEmail = !!formState.emailAddress.value; const isProgressiveSignUp = userSettings.signUp.progressive; + const legalConsentEnabled = userSettings.signUp.legal_consent_enabled; const fields = determineActiveFields({ attributes, @@ -110,7 +111,7 @@ function _SignUpStart(): JSX.Element { hasEmail, activeCommIdentifierType, isProgressiveSignUp, - legalConsentRequired: userSettings.signUp.legal_consent_enabled, + legalConsentRequired: legalConsentEnabled, }); const handleTokenFlow = () => { @@ -293,7 +294,7 @@ function _SignUpStart(): JSX.Element { /> )} - {!shouldShowForm && ( + {!shouldShowForm && legalConsentEnabled && ( Date: Wed, 23 Oct 2024 23:32:07 -0400 Subject: [PATCH 2/3] chore(repo): Add changeset --- .changeset/unlucky-coins-juggle.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/unlucky-coins-juggle.md diff --git a/.changeset/unlucky-coins-juggle.md b/.changeset/unlucky-coins-juggle.md new file mode 100644 index 00000000000..0609d4724d2 --- /dev/null +++ b/.changeset/unlucky-coins-juggle.md @@ -0,0 +1,5 @@ +--- +"@clerk/clerk-js": patch +--- + +Fix for legal consent rendered on the component when only social sign up is enabled From 4fc4e2c1c4118ec2cdf47cdd48b8eda178eb1811 Mon Sep 17 00:00:00 2001 From: Vaggelis Yfantis Date: Wed, 23 Oct 2024 23:41:58 -0400 Subject: [PATCH 3/3] chore(clerk-js): Rename variable name --- packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx index 7b66092fc0e..96c15e955d4 100644 --- a/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx +++ b/packages/clerk-js/src/ui/components/SignUp/SignUpStart.tsx @@ -103,7 +103,7 @@ function _SignUpStart(): JSX.Element { const hasTicket = !!formState.ticket.value; const hasEmail = !!formState.emailAddress.value; const isProgressiveSignUp = userSettings.signUp.progressive; - const legalConsentEnabled = userSettings.signUp.legal_consent_enabled; + const isLegalConsentEnabled = userSettings.signUp.legal_consent_enabled; const fields = determineActiveFields({ attributes, @@ -111,7 +111,7 @@ function _SignUpStart(): JSX.Element { hasEmail, activeCommIdentifierType, isProgressiveSignUp, - legalConsentRequired: legalConsentEnabled, + legalConsentRequired: isLegalConsentEnabled, }); const handleTokenFlow = () => { @@ -294,7 +294,7 @@ function _SignUpStart(): JSX.Element { /> )} - {!shouldShowForm && legalConsentEnabled && ( + {!shouldShowForm && isLegalConsentEnabled && (