Skip to content

Conversation

@alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Oct 28, 2024

Description

AFTER

Screen.Recording.2024-10-28.at.1.27.50.PM.mov

Fixes issue where delete account button was not becoming active when the field value matched the expected string value.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 348db3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter changed the title fix(translations): Ensure confirm delete account text aligns with prompt fix(localizations): Ensure confirm delete account text aligns with prompt Oct 28, 2024
Co-authored-by: Vaggelis Yfantis <me@octoper.me>
@alexcarpenter alexcarpenter marked this pull request as ready for review October 28, 2024 17:29
@alexcarpenter alexcarpenter merged commit cd2189a into main Oct 28, 2024
23 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/fix-fr-confirm-delete-account branch October 28, 2024 17:38
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
…ompt (#4420)

Co-authored-by: Vaggelis Yfantis <me@octoper.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants