fix(clerk-js): Move signup id check into an effect within continue step #4711
Conversation
🦋 Changeset detectedLatest commit: c3f3b76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| '@clerk/clerk-js': patch | ||
| --- | ||
|
|
||
| Fixes an issue during sign-up flow where a user lands on the continue step, and proceeds successfully through the sign-up process and gets redirected to AP sign-up due to signUp.id being undefined. |
There was a problem hiding this comment.
i'm a bit confused by this. I don't see how the useEffect solves the issue.
could you post a before/after video of the interactions ?
There was a problem hiding this comment.
Here is the issue currently present.
Screen.Recording.2024-12-04.at.1.14.03.PM.mov
There was a problem hiding this comment.
The SignUpContinue component seems to be rerendering causing signup.id to be undefined which triggers the navigation to AP. Chatting with @brkalow it seems to stem from onBeforeSetActive causing the component to re-render.
There was a problem hiding this comment.
@panteliselef added before/after to description
There was a problem hiding this comment.
thanks for providing these, i appreciate it. I can see how onBeforeSetActive could affect things
| '@clerk/clerk-js': patch | ||
| --- | ||
|
|
||
| Fixes an issue during sign-up flow where a user lands on the continue step, and proceeds successfully through the sign-up process and gets redirected to AP sign-up due to signUp.id being undefined. |
There was a problem hiding this comment.
thanks for providing these, i appreciate it. I can see how onBeforeSetActive could affect things
alexcarpenter
deleted the
alexcarpenter/sdki-785-signup-navigation-happening-unintentionally-during-continue
branch
Description
Fixes an issue during sign-up flow where a user lands on the continue step, and proceeds successfully through the sign-up process and gets redirected to AP sign-up due to
signUp.idbeing undefined.BEFORE:
Screen.Recording.2024-12-04.at.1.14.03.PM.mov
AFTER:
Screen.Recording.2024-12-04.at.1.39.48.PM.mov
Fixes SDKI-785
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change