From 902b5f92c2548585273803c546380b735bf5f5f8 Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Sun, 12 Jan 2025 21:45:16 -0600 Subject: [PATCH 1/2] fix bug where handleKeylessPrompt() causes ui chunk to load --- packages/clerk-js/src/core/clerk.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/clerk-js/src/core/clerk.ts b/packages/clerk-js/src/core/clerk.ts index eb91cc89b54..de52b1e20a3 100644 --- a/packages/clerk-js/src/core/clerk.ts +++ b/packages/clerk-js/src/core/clerk.ts @@ -2093,16 +2093,16 @@ export class Clerk implements ClerkInterface { }; #handleKeylessPrompt = () => { - void this.#componentControls?.ensureMounted().then(controls => { - if (this.#options.__internal_claimKeylessApplicationUrl) { + if (this.#options.__internal_claimKeylessApplicationUrl) { + void this.#componentControls?.ensureMounted().then(controls => { controls.updateProps({ options: { __internal_claimKeylessApplicationUrl: this.#options.__internal_claimKeylessApplicationUrl, __internal_copyInstanceKeysUrl: this.#options.__internal_copyInstanceKeysUrl, }, }); - } - }); + }); + } }; #buildUrl = ( From 3cc7099c0f542d9eb2de7100949fe36e09f16d3c Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Mon, 13 Jan 2025 09:16:22 -0600 Subject: [PATCH 2/2] adds changeset --- .changeset/tame-glasses-smoke.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tame-glasses-smoke.md diff --git a/.changeset/tame-glasses-smoke.md b/.changeset/tame-glasses-smoke.md new file mode 100644 index 00000000000..d44078bccef --- /dev/null +++ b/.changeset/tame-glasses-smoke.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Fixes an issue that caused Clerk's UI code to load even before components were rendered.