From 863e945d3f59f58c61e744346b0fd2191c41267d Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Fri, 17 Jan 2025 13:12:00 -0500 Subject: [PATCH 1/2] fix(clerk-js): Use modal props for modal methods --- packages/types/src/clerk.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/types/src/clerk.ts b/packages/types/src/clerk.ts index 3a98c31b73b..cbe87e5f0ac 100644 --- a/packages/types/src/clerk.ts +++ b/packages/types/src/clerk.ts @@ -156,7 +156,7 @@ export interface Clerk { * Opens the Clerk SignIn component in a modal. * @param props Optional sign in configuration parameters. */ - openSignIn: (props?: SignInProps) => void; + openSignIn: (props?: SignInModalProps) => void; /** * Closes the Clerk SignIn modal. @@ -190,7 +190,7 @@ export interface Clerk { * Opens the Clerk SignUp component in a modal. * @param props Optional props that will be passed to the SignUp component. */ - openSignUp: (props?: SignUpProps) => void; + openSignUp: (props?: SignUpModalProps) => void; /** * Closes the Clerk SignUp modal. @@ -201,7 +201,7 @@ export interface Clerk { * Opens the Clerk UserProfile modal. * @param props Optional props that will be passed to the UserProfile component. */ - openUserProfile: (props?: UserProfileProps) => void; + openUserProfile: (props?: UserProfileModalProps) => void; /** * Closes the Clerk UserProfile modal. @@ -212,7 +212,7 @@ export interface Clerk { * Opens the Clerk OrganizationProfile modal. * @param props Optional props that will be passed to the OrganizationProfile component. */ - openOrganizationProfile: (props?: OrganizationProfileProps) => void; + openOrganizationProfile: (props?: OrganizationProfileModalProps) => void; /** * Closes the Clerk OrganizationProfile modal. @@ -223,7 +223,7 @@ export interface Clerk { * Opens the Clerk CreateOrganization modal. * @param props Optional props that will be passed to the CreateOrganization component. */ - openCreateOrganization: (props?: CreateOrganizationProps) => void; + openCreateOrganization: (props?: CreateOrganizationModalProps) => void; /** * Closes the Clerk CreateOrganization modal. @@ -234,7 +234,7 @@ export interface Clerk { * Opens the Clerk Waitlist modal. * @param props Optional props that will be passed to the Waitlist component. */ - openWaitlist: (props?: WaitlistProps) => void; + openWaitlist: (props?: WaitlistModalProps) => void; /** * Closes the Clerk Waitlist modal. From fb9327c0a644b6b260e67231e3ee60321346dc77 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Fri, 17 Jan 2025 13:20:19 -0500 Subject: [PATCH 2/2] add changeset --- .changeset/gorgeous-suns-cheer.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/gorgeous-suns-cheer.md diff --git a/.changeset/gorgeous-suns-cheer.md b/.changeset/gorgeous-suns-cheer.md new file mode 100644 index 00000000000..77bb45975fb --- /dev/null +++ b/.changeset/gorgeous-suns-cheer.md @@ -0,0 +1,5 @@ +--- +'@clerk/types': patch +--- + +Update modal methods to use the correct types.