From b596c93ea0d264b8e3b21896f9ff28119e83339a Mon Sep 17 00:00:00 2001 From: George Desipris Date: Thu, 3 Nov 2022 18:14:52 +0200 Subject: [PATCH] fix(clerk-js): Disable scroll to top for OrganizationProfile navbar --- .../OrganizationProfile/OrganizationMembers.tsx | 2 +- .../OrganizationProfile/OrganizationSettings.tsx | 2 +- packages/clerk-js/src/ui/elements/Navbar.tsx | 13 +++++++++---- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationMembers.tsx b/packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationMembers.tsx index 0556e093a0c..7d5b8069e17 100644 --- a/packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationMembers.tsx +++ b/packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationMembers.tsx @@ -41,7 +41,7 @@ export const OrganizationMembers = () => { justify={'between'} align={'center'} > - + { // elementId={descriptors.profilePage.setId('account')} gap={8} > - + void; close: () => void export const [NavbarContext, useNavbarContext, useUnsafeNavbarContext] = createContextAndHook('NavbarContext'); -export const NavbarContextProvider = (props: React.PropsWithChildren<{}>) => { +export const NavbarContextProvider = (props: React.PropsWithChildren>) => { const [isOpen, setIsOpen] = React.useState(false); const open = React.useCallback(() => setIsOpen(true), []); const close = React.useCallback(() => setIsOpen(false), []); @@ -30,7 +30,12 @@ export const NavbarContextProvider = (props: React.PropsWithChildren<{}>) => { return {props.children}; }; -export type NavbarRoute = { name: LocalizationKey; id: string; icon: React.ComponentType; path: string }; +export type NavbarRoute = { + name: LocalizationKey; + id: string; + icon: React.ComponentType; + path: string; +}; type RouteId = NavbarRoute['id']; type NavBarProps = { contentRef: React.RefObject; @@ -135,7 +140,7 @@ export const NavBar = (props: NavBarProps) => { ); }; -const NavbarContainer = (props: React.PropsWithChildren<{}>) => { +const NavbarContainer = (props: React.PropsWithChildren>) => { return ( ) => { ); }; -const MobileNavbarContainer = (props: React.PropsWithChildren<{}>) => { +const MobileNavbarContainer = (props: React.PropsWithChildren>) => { const navbarContext = useNavbarContext(); const { floating, isOpen, open, close } = usePopover({ defaultOpen: false, autoUpdate: false });