From 6db357aa8b60a96d5fd737266d9b2eaf062cd399 Mon Sep 17 00:00:00 2001 From: Philip Rothschild Date: Sat, 8 Feb 2025 17:26:54 +0100 Subject: [PATCH 1/3] feat: Add localization of 'Add a passkey' button --- .../clerk-js/src/ui/components/UserProfile/PasskeySection.tsx | 2 +- packages/localizations/src/en-US.ts | 1 + packages/types/src/localization.ts | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx b/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx index 6f327377d99..581f47c4014 100644 --- a/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx +++ b/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx @@ -222,7 +222,7 @@ const AddPasskeyButton = ({ onClick }: { onClick?: () => void }) => { return ( ); diff --git a/packages/localizations/src/en-US.ts b/packages/localizations/src/en-US.ts index dbfe5f3068b..8a9bba153a5 100644 --- a/packages/localizations/src/en-US.ts +++ b/packages/localizations/src/en-US.ts @@ -864,6 +864,7 @@ export const enUS: LocalizationResource = { }, }, passkeysSection: { + addButton: 'Add a passkey', menuAction__destructive: 'Remove', menuAction__rename: 'Rename', title: 'Passkeys', diff --git a/packages/types/src/localization.ts b/packages/types/src/localization.ts index b873a93554f..1d6548725b4 100644 --- a/packages/types/src/localization.ts +++ b/packages/types/src/localization.ts @@ -435,6 +435,7 @@ type _LocalizationResource = { }; passkeysSection: { title: LocalizationValue; + addButton: LocalizationValue; menuAction__rename: LocalizationValue; menuAction__destructive: LocalizationValue; }; From 88c0e01b9d9b56b60b69bc1956ea592413f07c3c Mon Sep 17 00:00:00 2001 From: panteliselef Date: Mon, 10 Feb 2025 11:50:07 +0200 Subject: [PATCH 2/3] rename key to `primaryButton` --- .../clerk-js/src/ui/components/UserProfile/PasskeySection.tsx | 2 +- packages/localizations/src/en-US.ts | 2 +- packages/types/src/localization.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx b/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx index 581f47c4014..baaa23ecab8 100644 --- a/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx +++ b/packages/clerk-js/src/ui/components/UserProfile/PasskeySection.tsx @@ -222,7 +222,7 @@ const AddPasskeyButton = ({ onClick }: { onClick?: () => void }) => { return ( ); diff --git a/packages/localizations/src/en-US.ts b/packages/localizations/src/en-US.ts index 8a9bba153a5..0ba8e0a066f 100644 --- a/packages/localizations/src/en-US.ts +++ b/packages/localizations/src/en-US.ts @@ -864,7 +864,7 @@ export const enUS: LocalizationResource = { }, }, passkeysSection: { - addButton: 'Add a passkey', + primaryButton: 'Add a passkey', menuAction__destructive: 'Remove', menuAction__rename: 'Rename', title: 'Passkeys', diff --git a/packages/types/src/localization.ts b/packages/types/src/localization.ts index 1d6548725b4..d19932cbee1 100644 --- a/packages/types/src/localization.ts +++ b/packages/types/src/localization.ts @@ -435,7 +435,7 @@ type _LocalizationResource = { }; passkeysSection: { title: LocalizationValue; - addButton: LocalizationValue; + primaryButton: LocalizationValue; menuAction__rename: LocalizationValue; menuAction__destructive: LocalizationValue; }; From 9cd1a434f99f5aa55f6261ae9ace1acb8bfea8ae Mon Sep 17 00:00:00 2001 From: panteliselef Date: Mon, 10 Feb 2025 11:53:27 +0200 Subject: [PATCH 3/3] Create silver-gifts-smile.md --- .changeset/silver-gifts-smile.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/silver-gifts-smile.md diff --git a/.changeset/silver-gifts-smile.md b/.changeset/silver-gifts-smile.md new file mode 100644 index 00000000000..f28ab7be56a --- /dev/null +++ b/.changeset/silver-gifts-smile.md @@ -0,0 +1,7 @@ +--- +"@clerk/clerk-js": patch +"@clerk/localizations": patch +"@clerk/types": patch +--- + +Replaces hard-coded string `"Add a passkey"` with a new localization key `userProfile.start.passkeysSection.primaryButton`