From 6dc10cb7360e8cf6ab99cf3c9d89c0828047f50b Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Tue, 1 Apr 2025 11:47:23 -0500 Subject: [PATCH 1/3] Removes telemetry event from clerkMiddelware() that is firing more than intended --- .changeset/spotty-schools-juggle.md | 5 +++++ packages/nextjs/src/server/clerkMiddleware.ts | 9 --------- 2 files changed, 5 insertions(+), 9 deletions(-) create mode 100644 .changeset/spotty-schools-juggle.md diff --git a/.changeset/spotty-schools-juggle.md b/.changeset/spotty-schools-juggle.md new file mode 100644 index 00000000000..1df2de38fb0 --- /dev/null +++ b/.changeset/spotty-schools-juggle.md @@ -0,0 +1,5 @@ +--- +'@clerk/nextjs': patch +--- + +Remove telemtry event from `clerkMiddleware()`. diff --git a/packages/nextjs/src/server/clerkMiddleware.ts b/packages/nextjs/src/server/clerkMiddleware.ts index b64f756426c..10b114cb9d5 100644 --- a/packages/nextjs/src/server/clerkMiddleware.ts +++ b/packages/nextjs/src/server/clerkMiddleware.ts @@ -1,7 +1,6 @@ import type { AuthObject, ClerkClient } from '@clerk/backend'; import type { AuthenticateRequestOptions, ClerkRequest, RedirectFun, RequestState } from '@clerk/backend/internal'; import { AuthStatus, constants, createClerkRequest, createRedirect } from '@clerk/backend/internal'; -import { eventMethodCalled } from '@clerk/shared/telemetry'; import { notFound as nextjsNotFound } from 'next/navigation'; import type { NextMiddleware, NextRequest } from 'next/server'; import { NextResponse } from 'next/server'; @@ -128,14 +127,6 @@ export const clerkMiddleware = ((...args: unknown[]): NextMiddleware | NextMiddl clerkMiddlewareRequestDataStore.set('requestData', options); const resolvedClerkClient = await clerkClient(); - resolvedClerkClient.telemetry.record( - eventMethodCalled('clerkMiddleware', { - handler: Boolean(handler), - satellite: Boolean(options.isSatellite), - proxy: Boolean(options.proxyUrl), - }), - ); - if (options.debug) { logger.enable(); } From 7be8258490dc9fec8eae967a3d1c906c0e050998 Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Tue, 1 Apr 2025 11:52:30 -0500 Subject: [PATCH 2/3] Also remove from other framework SDKs --- packages/astro/src/server/clerk-middleware.ts | 9 --------- packages/nuxt/src/runtime/server/clerkMiddleware.ts | 9 --------- 2 files changed, 18 deletions(-) diff --git a/packages/astro/src/server/clerk-middleware.ts b/packages/astro/src/server/clerk-middleware.ts index 1b80cb258ff..edf7398b4ec 100644 --- a/packages/astro/src/server/clerk-middleware.ts +++ b/packages/astro/src/server/clerk-middleware.ts @@ -3,7 +3,6 @@ import type { AuthenticateRequestOptions, ClerkRequest, RedirectFun, RequestStat import { AuthStatus, constants, createClerkRequest, createRedirect } from '@clerk/backend/internal'; import { isDevelopmentFromPublishableKey, isDevelopmentFromSecretKey } from '@clerk/shared/keys'; import { isHttpOrHttps } from '@clerk/shared/proxy'; -import { eventMethodCalled } from '@clerk/shared/telemetry'; import { handleValueOrFn } from '@clerk/shared/utils'; import type { APIContext } from 'astro'; @@ -68,14 +67,6 @@ export const clerkMiddleware: ClerkMiddleware = (...args: unknown[]): any => { const clerkRequest = createClerkRequest(context.request); - clerkClient(context).telemetry.record( - eventMethodCalled('clerkMiddleware', { - handler: Boolean(handler), - satellite: Boolean(options.isSatellite), - proxy: Boolean(options.proxyUrl), - }), - ); - const requestState = await clerkClient(context).authenticateRequest( clerkRequest, createAuthenticateRequestOptions(clerkRequest, options, context), diff --git a/packages/nuxt/src/runtime/server/clerkMiddleware.ts b/packages/nuxt/src/runtime/server/clerkMiddleware.ts index 8fa0c999318..bee0214f968 100644 --- a/packages/nuxt/src/runtime/server/clerkMiddleware.ts +++ b/packages/nuxt/src/runtime/server/clerkMiddleware.ts @@ -1,6 +1,5 @@ import type { AuthenticateRequestOptions } from '@clerk/backend/internal'; import { AuthStatus, constants } from '@clerk/backend/internal'; -import { eventMethodCalled } from '@clerk/shared/telemetry'; import type { EventHandler } from 'h3'; import { createError, eventHandler, setResponseHeader } from 'h3'; @@ -80,14 +79,6 @@ export const clerkMiddleware: ClerkMiddleware = (...args: unknown[]) => { return eventHandler(async event => { const clerkRequest = toWebRequest(event); - clerkClient(event).telemetry.record( - eventMethodCalled('clerkMiddleware', { - handler: Boolean(handler), - satellite: Boolean(options.isSatellite), - proxy: Boolean(options.proxyUrl), - }), - ); - const requestState = await clerkClient(event).authenticateRequest(clerkRequest, options); const locationHeader = requestState.headers.get(constants.Headers.Location); From bbdbe99858dcb3e3b7876a8f559a4463c2c41f43 Mon Sep 17 00:00:00 2001 From: Bryce Kalow Date: Tue, 1 Apr 2025 12:03:09 -0500 Subject: [PATCH 3/3] Update .changeset/spotty-schools-juggle.md --- .changeset/spotty-schools-juggle.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.changeset/spotty-schools-juggle.md b/.changeset/spotty-schools-juggle.md index 1df2de38fb0..46ddb5e1045 100644 --- a/.changeset/spotty-schools-juggle.md +++ b/.changeset/spotty-schools-juggle.md @@ -1,5 +1,7 @@ --- '@clerk/nextjs': patch +'@clerk/astro': patch +'@clerk/nuxt': patch --- Remove telemtry event from `clerkMiddleware()`.