From 1d374ddb6d91a447691d485e044d39b803a78c7a Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Wed, 16 Apr 2025 17:42:59 -0400 Subject: [PATCH 1/2] fix(clerk-js): Reset definition list components margins --- packages/clerk-js/src/ui/elements/Header.tsx | 8 +++++++- packages/clerk-js/src/ui/primitives/Dd.tsx | 3 +++ packages/clerk-js/src/ui/primitives/Dl.tsx | 3 +++ packages/clerk-js/src/ui/primitives/Dt.tsx | 3 +++ 4 files changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/clerk-js/src/ui/elements/Header.tsx b/packages/clerk-js/src/ui/elements/Header.tsx index 6c74288fc2c..a9880c5404b 100644 --- a/packages/clerk-js/src/ui/elements/Header.tsx +++ b/packages/clerk-js/src/ui/elements/Header.tsx @@ -78,12 +78,18 @@ const BackLink = React.memo((props: PropsOfComponent): JSX.Element display: 'inline-flex', alignItems: 'center', gap: t.space.$2, + '&:hover': { + textDecoration: 'none', + }, }, sx, ]} {...rest} > - + ({ color: t.colors.$colorText })} + /> {children} ); diff --git a/packages/clerk-js/src/ui/primitives/Dd.tsx b/packages/clerk-js/src/ui/primitives/Dd.tsx index 15d28c26a05..040e46bb8da 100644 --- a/packages/clerk-js/src/ui/primitives/Dd.tsx +++ b/packages/clerk-js/src/ui/primitives/Dd.tsx @@ -10,6 +10,9 @@ export const Dd = React.forwardRef((props, ref) = return ( diff --git a/packages/clerk-js/src/ui/primitives/Dl.tsx b/packages/clerk-js/src/ui/primitives/Dl.tsx index d1921fba210..c7c43fff1ba 100644 --- a/packages/clerk-js/src/ui/primitives/Dl.tsx +++ b/packages/clerk-js/src/ui/primitives/Dl.tsx @@ -10,6 +10,9 @@ export const Dl = React.forwardRef((props, ref) = return ( diff --git a/packages/clerk-js/src/ui/primitives/Dt.tsx b/packages/clerk-js/src/ui/primitives/Dt.tsx index 2d55e67ec6b..4879596c616 100644 --- a/packages/clerk-js/src/ui/primitives/Dt.tsx +++ b/packages/clerk-js/src/ui/primitives/Dt.tsx @@ -10,6 +10,9 @@ export const Dt = React.forwardRef((props, ref) = return ( From bd9ca2997ca90f43b84f73a911a0559a963ac5c7 Mon Sep 17 00:00:00 2001 From: Alex Carpenter Date: Wed, 16 Apr 2025 17:46:34 -0400 Subject: [PATCH 2/2] add changeset --- .changeset/eighty-suns-argue.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eighty-suns-argue.md diff --git a/.changeset/eighty-suns-argue.md b/.changeset/eighty-suns-argue.md new file mode 100644 index 00000000000..14717f51aec --- /dev/null +++ b/.changeset/eighty-suns-argue.md @@ -0,0 +1,5 @@ +--- +'@clerk/clerk-js': patch +--- + +Ensure margin is reset on definition list components to prevent browser default styling leaking in.