From edcbf458d9a9b87f5391420c30ab5d72b165fbe8 Mon Sep 17 00:00:00 2001 From: Nikos Douvlis Date: Mon, 5 May 2025 17:47:36 +0300 Subject: [PATCH 1/8] refactor(clerk-js): Remove experimental prefix from mount and unmount pricing table methods --- packages/clerk-js/src/core/clerk.ts | 4 ++-- packages/react/src/components/uiComponents.tsx | 4 ++-- packages/react/src/isomorphicClerk.ts | 10 +++++----- packages/types/src/clerk.ts | 4 ++-- .../vue/src/components/ui-components/PricingTable.vue | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/clerk-js/src/core/clerk.ts b/packages/clerk-js/src/core/clerk.ts index 2b4244d9ce7..0d6291ef5de 100644 --- a/packages/clerk-js/src/core/clerk.ts +++ b/packages/clerk-js/src/core/clerk.ts @@ -1006,7 +1006,7 @@ export class Clerk implements ClerkInterface { void this.#componentControls?.ensureMounted().then(controls => controls.unmountComponent({ node })); }; - public __experimental_mountPricingTable = (node: HTMLDivElement, props?: PricingTableProps): void => { + public mountPricingTable = (node: HTMLDivElement, props?: PricingTableProps): void => { this.assertComponentsReady(this.#componentControls); if (disabledBillingFeature(this, this.environment)) { if (this.#instanceType === 'development') { @@ -1028,7 +1028,7 @@ export class Clerk implements ClerkInterface { this.telemetry?.record(eventPrebuiltComponentMounted('PricingTable', props)); }; - public __experimental_unmountPricingTable = (node: HTMLDivElement): void => { + public unmountPricingTable = (node: HTMLDivElement): void => { this.assertComponentsReady(this.#componentControls); void this.#componentControls.ensureMounted().then(controls => controls.unmountComponent({ diff --git a/packages/react/src/components/uiComponents.tsx b/packages/react/src/components/uiComponents.tsx index 9556050ef29..efba0fe8130 100644 --- a/packages/react/src/components/uiComponents.tsx +++ b/packages/react/src/components/uiComponents.tsx @@ -588,8 +588,8 @@ export const PricingTable = withClerk( {clerk.loaded && ( { - clerkjs.__experimental_mountPricingTable(node, props); + clerkjs.mountPricingTable(node, props); }); /** @@ -1034,17 +1034,17 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk { } }; - __experimental_mountPricingTable = (node: HTMLDivElement, props?: PricingTableProps) => { + mountPricingTable = (node: HTMLDivElement, props?: PricingTableProps) => { if (this.clerkjs && this.loaded) { - this.clerkjs.__experimental_mountPricingTable(node, props); + this.clerkjs.mountPricingTable(node, props); } else { this.premountPricingTableNodes.set(node, props); } }; - __experimental_unmountPricingTable = (node: HTMLDivElement) => { + unmountPricingTable = (node: HTMLDivElement) => { if (this.clerkjs && this.loaded) { - this.clerkjs.__experimental_unmountPricingTable(node); + this.clerkjs.unmountPricingTable(node); } else { this.premountPricingTableNodes.delete(node); } diff --git a/packages/types/src/clerk.ts b/packages/types/src/clerk.ts index 10d6051f4c5..1d5177a9442 100644 --- a/packages/types/src/clerk.ts +++ b/packages/types/src/clerk.ts @@ -448,7 +448,7 @@ export interface Clerk { * @param targetNode Target node to mount the PricingTable component. * @param props configuration parameters. */ - __experimental_mountPricingTable: (targetNode: HTMLDivElement, props?: PricingTableProps) => void; + mountPricingTable: (targetNode: HTMLDivElement, props?: PricingTableProps) => void; /** * Unmount a pricing table component from the target element. @@ -456,7 +456,7 @@ export interface Clerk { * * @param targetNode Target node to unmount the PricingTable component from. */ - __experimental_unmountPricingTable: (targetNode: HTMLDivElement) => void; + unmountPricingTable: (targetNode: HTMLDivElement) => void; /** * Register a listener that triggers a callback each time important Clerk resources are changed. diff --git a/packages/vue/src/components/ui-components/PricingTable.vue b/packages/vue/src/components/ui-components/PricingTable.vue index 9830f9803b6..a3fb70cd5db 100644 --- a/packages/vue/src/components/ui-components/PricingTable.vue +++ b/packages/vue/src/components/ui-components/PricingTable.vue @@ -9,8 +9,8 @@ const props = defineProps();