Skip to content

fix(clerk-js): Remove navbar icon shift in safari #5887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

fix(clerk-js): Remove navbar icon shift in safari #5887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
905f302
fix(clerk-js): Remove navbar icon shift in safari
alexcarpenter May 8, 2025
1fb3ffe
add changeset
alexcarpenter May 8, 2025
487a757
add comment
alexcarpenter May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-gifts-juggle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': patch
---

Fixes issue in Safari where navigating between profile tabs caused the navbar icons to shift unexpectedly.
6 changes: 5 additions & 1 deletion packages/clerk-js/src/ui/elements/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,11 @@ const NavButton = (props: NavButtonProps) => {
elementDescriptor={iconElementDescriptor}
elementId={iconElementId}
icon={icon}
sx={{ opacity: isActive ? 1 : 0.7 }}
sx={{
opacity: isActive ? 1 : 0.7,
// Fixes a bug in Safari where the icon shifts when navigating between routes.
transform: 'translateZ(0)',
Copy link
Member

@panteliselef panteliselef May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment, I don't think it will be easy to understand why transform is used.

}}
/>
{children}
</Button>
Expand Down