Skip to content

Conversation

@5ergiu
Copy link
Contributor

@5ergiu 5ergiu commented Aug 25, 2025

Description

Updated Romanian translations,

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features
    • Added complete Romanian (ro-RO) localization across the app, covering API key management, billing/commerce, organization profiles, error messages, and form labels/placeholders.
    • Romanian can now be selected for a fully localized user experience.
    • Improved translation coverage ensures consistent terminology and clearer prompts for Romanian-speaking users.

@vercel
Copy link

vercel bot commented Aug 25, 2025

@5ergiu is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 25, 2025

Warning

Rate limit exceeded

@5ergiu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 66af60f and 81a1b29.

📒 Files selected for processing (1)
  • .changeset/complete-romanian-localization.md (1 hunks)
📝 Walkthrough

Walkthrough

Adds a new changeset file completing the Romanian (ro-RO) localization for @clerk/localizations. The changeset provides translations across API key management, commerce and billing, organization profile, error messages, and form labels/placeholders. It also updates packaging configuration to include ro-RO in the package.json files array for publishing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Can you also add a changeset for this one? Similar to https://github.com/clerk/javascript/pull/6533/files

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

🦋 Changeset detected

Latest commit: 81a1b29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Minor
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@5ergiu
Copy link
Contributor Author

5ergiu commented Aug 27, 2025

Thank you. Can you also add a changeset for this one? Similar to https://github.com/clerk/javascript/pull/6533/files

Sure thing! Added the changeset.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.changeset/complete-romanian-localization.md (1)

5-15: Tighten wording, fix list parallelism, and remove trailing spaces

Minor grammar/style polish and one trailing double-space on Line 9. Suggested rewrite keeps the same meaning but is cleaner and consistent.

-Complete Romanian (ro-RO) localization with all missing translations
+Complete Romanian (ro-RO) localization

-This update completes the Romanian localization by:
-- Translating all undefined API key management strings
-- Adding complete commerce/billing translations  
-- Completing organization profile translations
-- Adding all missing error messages
-- Including form labels and placeholders
-- Adding ro-RO to package.json files array for proper publishing
+This update:
+- Translates missing API key management strings.
+- Adds complete commerce and billing translations.
+- Completes organization profile translations.
+- Adds missing error messages.
+- Includes form labels and placeholders.
+- Ensures ro-RO is included in the package.json files array for publishing.

-The Romanian localization now provides a complete user experience for Romanian-speaking users.
+The Romanian localization now provides a complete experience for Romanian-speaking users.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8002941 and d5aceef.

📒 Files selected for processing (1)
  • .changeset/complete-romanian-localization.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/complete-romanian-localization.md
🪛 LanguageTool
.changeset/complete-romanian-localization.md

[grammar] ~7-~7: There might be a mistake here.
Context: ... completes the Romanian localization by: - Translating all undefined API key manage...

(QB_NEW_EN)


[grammar] ~8-~8: There might be a mistake here.
Context: ...all undefined API key management strings - Adding complete commerce/billing transla...

(QB_NEW_EN)


[grammar] ~9-~9: There might be a mistake here.
Context: ...g complete commerce/billing translations - Completing organization profile translat...

(QB_NEW_EN)


[grammar] ~10-~10: There might be a mistake here.
Context: ...leting organization profile translations - Adding all missing error messages - Incl...

(QB_NEW_EN)


[grammar] ~11-~11: There might be a mistake here.
Context: ...ions - Adding all missing error messages - Including form labels and placeholders -...

(QB_NEW_EN)


[grammar] ~12-~12: There might be a mistake here.
Context: ...- Including form labels and placeholders - Adding ro-RO to package.json files array...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (3)
.changeset/complete-romanian-localization.md (3)

1-3: Frontmatter looks valid for Changesets

Package scoped correctly and release type specified. Using Changesets under .changeset/ complies with our publishing guidelines.


2-2: Confirm release bump (minor vs patch)

If this PR only adds/updates translations, a patch could be sufficient; if it introduces a newly published locale or expands public surface (e.g., adding ro-RO to published files), minor is reasonable. Please confirm intent.

Optional diff if you decide to switch to patch:

-'@clerk/localizations': minor
+'@clerk/localizations': patch

13-13: ro-RO Localization Verified

All checks confirm that the Romanian locale has been fully integrated:

  • packages/localizations/package.json
    • files array includes "ro-RO"
  • packages/localizations/src/utils/generate.ts
    • imports roRO and calls run(roRO, 'ro-RO')
  • packages/localizations/src/ro-RO.ts
    • defines locale: 'ro-RO' and is exported in src/index.ts

No further action needed—ready to merge.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.changeset/complete-romanian-localization.md (1)

1-12: Add required YAML frontmatter to Changeset

The changeset file .changeset/complete-romanian-localization.md is missing its frontmatter block, so the release pipeline cannot pick up this update. You need to specify the affected package and bump type at the top of the file.

• Insert at the very top of the file:

---
'@clerk/localizations': minor
---

(If translation updates in your policy count as fixes rather than new features, change minor to patch.)

• Then replace the existing title/body with a concise summary. For example:

 Complete Romanian (ro-RO) localization

 This update:
-  • Translates missing API key management strings.
-  • Adds complete commerce and billing translations.
-  • Completes organization profile translations.
-  • Adds missing error messages.
-  • Includes form labels and placeholders.
-  • Ensures ro-RO is included in the package.json files array for publishing.
-
- The Romanian localization now provides a complete experience for Romanian-speaking users.
+---
+'@clerk/localizations': minor
+---
+
+Add complete Romanian (ro-RO) localization: API key management, commerce/billing, organization profile, error messages, and form labels/placeholders. Ensure ro-RO is exported and published.
🧹 Nitpick comments (1)
.changeset/complete-romanian-localization.md (1)

1-12: Trim PR-style details from the changeset body.

Changeset summaries should be a terse release note. Implementation checklists and packaging notes belong in the PR description.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d5aceef and 66af60f.

📒 Files selected for processing (1)
  • .changeset/complete-romanian-localization.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**

📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)

Automated releases must use Changesets.

Files:

  • .changeset/complete-romanian-localization.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: semgrep-cloud-platform/scan

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6629

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6629

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6629

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6629

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6629

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6629

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6629

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6629

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6629

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6629

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6629

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6629

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6629

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6629

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6629

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6629

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6629

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6629

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6629

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6629

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6629

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6629

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6629

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6629

commit: 81a1b29

@nikosdouvlis nikosdouvlis merged commit 12b19d4 into clerk:main Aug 27, 2025
11 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants