-
Notifications
You must be signed in to change notification settings - Fork 403
chore(localizations): Update Romanian translations #6629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@5ergiu is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded@5ergiu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new changeset file completing the Romanian (ro-RO) localization for @clerk/localizations. The changeset provides translations across API key management, commerce and billing, organization profile, error messages, and form labels/placeholders. It also updates packaging configuration to include ro-RO in the package.json Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Can you also add a changeset for this one? Similar to https://github.com/clerk/javascript/pull/6533/files
🦋 Changeset detectedLatest commit: 81a1b29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sure thing! Added the changeset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/complete-romanian-localization.md (1)
5-15: Tighten wording, fix list parallelism, and remove trailing spacesMinor grammar/style polish and one trailing double-space on Line 9. Suggested rewrite keeps the same meaning but is cleaner and consistent.
-Complete Romanian (ro-RO) localization with all missing translations +Complete Romanian (ro-RO) localization -This update completes the Romanian localization by: -- Translating all undefined API key management strings -- Adding complete commerce/billing translations -- Completing organization profile translations -- Adding all missing error messages -- Including form labels and placeholders -- Adding ro-RO to package.json files array for proper publishing +This update: +- Translates missing API key management strings. +- Adds complete commerce and billing translations. +- Completes organization profile translations. +- Adds missing error messages. +- Includes form labels and placeholders. +- Ensures ro-RO is included in the package.json files array for publishing. -The Romanian localization now provides a complete user experience for Romanian-speaking users. +The Romanian localization now provides a complete experience for Romanian-speaking users.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/complete-romanian-localization.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/complete-romanian-localization.md
🪛 LanguageTool
.changeset/complete-romanian-localization.md
[grammar] ~7-~7: There might be a mistake here.
Context: ... completes the Romanian localization by: - Translating all undefined API key manage...
(QB_NEW_EN)
[grammar] ~8-~8: There might be a mistake here.
Context: ...all undefined API key management strings - Adding complete commerce/billing transla...
(QB_NEW_EN)
[grammar] ~9-~9: There might be a mistake here.
Context: ...g complete commerce/billing translations - Completing organization profile translat...
(QB_NEW_EN)
[grammar] ~10-~10: There might be a mistake here.
Context: ...leting organization profile translations - Adding all missing error messages - Incl...
(QB_NEW_EN)
[grammar] ~11-~11: There might be a mistake here.
Context: ...ions - Adding all missing error messages - Including form labels and placeholders -...
(QB_NEW_EN)
[grammar] ~12-~12: There might be a mistake here.
Context: ...- Including form labels and placeholders - Adding ro-RO to package.json files array...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (3)
.changeset/complete-romanian-localization.md (3)
1-3: Frontmatter looks valid for ChangesetsPackage scoped correctly and release type specified. Using Changesets under .changeset/ complies with our publishing guidelines.
2-2: Confirm release bump (minor vs patch)If this PR only adds/updates translations, a patch could be sufficient; if it introduces a newly published locale or expands public surface (e.g., adding ro-RO to published files), minor is reasonable. Please confirm intent.
Optional diff if you decide to switch to patch:
-'@clerk/localizations': minor +'@clerk/localizations': patch
13-13: ro-RO Localization VerifiedAll checks confirm that the Romanian locale has been fully integrated:
- packages/localizations/package.json
• files array includes"ro-RO"- packages/localizations/src/utils/generate.ts
• importsroROand callsrun(roRO, 'ro-RO')- packages/localizations/src/ro-RO.ts
• defineslocale: 'ro-RO'and is exported insrc/index.tsNo further action needed—ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.changeset/complete-romanian-localization.md (1)
1-12: Add required YAML frontmatter to ChangesetThe changeset file
.changeset/complete-romanian-localization.mdis missing its frontmatter block, so the release pipeline cannot pick up this update. You need to specify the affected package and bump type at the top of the file.• Insert at the very top of the file:
--- '@clerk/localizations': minor ---(If translation updates in your policy count as fixes rather than new features, change
minortopatch.)• Then replace the existing title/body with a concise summary. For example:
Complete Romanian (ro-RO) localization This update: - • Translates missing API key management strings. - • Adds complete commerce and billing translations. - • Completes organization profile translations. - • Adds missing error messages. - • Includes form labels and placeholders. - • Ensures ro-RO is included in the package.json files array for publishing. - - The Romanian localization now provides a complete experience for Romanian-speaking users. +--- +'@clerk/localizations': minor +--- + +Add complete Romanian (ro-RO) localization: API key management, commerce/billing, organization profile, error messages, and form labels/placeholders. Ensure ro-RO is exported and published.
🧹 Nitpick comments (1)
.changeset/complete-romanian-localization.md (1)
1-12: Trim PR-style details from the changeset body.Changeset summaries should be a terse release note. Implementation checklists and packaging notes belong in the PR description.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.changeset/complete-romanian-localization.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/**
📄 CodeRabbit inference engine (.cursor/rules/monorepo.mdc)
Automated releases must use Changesets.
Files:
.changeset/complete-romanian-localization.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: semgrep-cloud-platform/scan
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Description
Updated Romanian translations,
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit