Skip to content

Conversation

@LauraBeatris
Copy link
Member

Description

Remove deprecated saml strategy in favor of enterprise_sso

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this Nov 27, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2025

🦋 Changeset detected

Latest commit: 933436a

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clerk-js-sandbox Ready Ready Preview Comment Nov 27, 2025 10:26pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch laura/user-4048-deprecate-samlstrategy-in-favor-of-enterprisessostrategy

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@LauraBeatris LauraBeatris requested a review from a team November 27, 2025 22:24
@LauraBeatris LauraBeatris changed the title chore(clerk-js,shared): Remove deprecated saml strategy chore(clerk-js,shared,ui): Remove deprecated saml strategy Nov 27, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 27, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7326

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7326

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7326

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7326

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7326

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7326

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7326

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7326

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7326

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7326

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7326

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7326

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7326

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7326

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7326

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7326

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7326

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7326

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@7326

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7326

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7326

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7326

commit: 933436a

@LauraBeatris
Copy link
Member Author

!allow-major

@LauraBeatris LauraBeatris merged commit 3dac245 into vincent-and-the-doctor Nov 27, 2025
66 of 71 checks passed
@LauraBeatris LauraBeatris deleted the laura/user-4048-deprecate-samlstrategy-in-favor-of-enterprisessostrategy branch November 27, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants