docs(repo): clarify changesets describe user-facing changes#8729
Conversation
🦋 Changeset detectedLatest commit: 12e7ed7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR updates contributor documentation in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
AGENTS.md (1)
10-10: 💤 Low valueOptional: Consider adding a concrete example for clarity.
The updated guidance is clear and comprehensive. To further strengthen contributor understanding, you could optionally add a brief inline example distinguishing user-facing vs implementation-focused changeset descriptions:
Example format:
✓ "Added support for custom error messages in signIn()" ✗ "Refactored AuthService.handleSignIn to use new ErrorHandler class"However, given that this is a rules section and CONTRIBUTING.md is referenced for detailed guidance, the current text is already functional and actionable.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AGENTS.md` at line 10, Add a brief concrete example to the changeset guidance showing a user-facing description vs an implementation-focused one to clarify intent; update the paragraph that references `pnpm changeset` / `pnpm changeset:empty` (the changeset guidance) by appending a one-line good example and one-line bad example illustrating the difference (e.g., a consumer-facing change like "Added support for custom error messages in signIn()" versus an implementation note like "Refactored AuthService.handleSignIn to use new ErrorHandler class"), so contributors can quickly see the expected phrasing when creating a changeset.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@AGENTS.md`:
- Line 10: Add a brief concrete example to the changeset guidance showing a
user-facing description vs an implementation-focused one to clarify intent;
update the paragraph that references `pnpm changeset` / `pnpm changeset:empty`
(the changeset guidance) by appending a one-line good example and one-line bad
example illustrating the difference (e.g., a consumer-facing change like "Added
support for custom error messages in signIn()" versus an implementation note
like "Refactored AuthService.handleSignIn to use new ErrorHandler class"), so
contributors can quickly see the expected phrasing when creating a changeset.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: c7d2fd17-eb6d-49dc-ae9e-ff4e8a605e9c
📒 Files selected for processing (2)
.changeset/bright-parrots-play.mdAGENTS.md
Description
Expands the changeset rule in
AGENTS.mdto clarify that a changeset is a changelog entry for users upgrading the package, not a summary of the work done in the PR. It should describe the user-facing change rather than implementation details of the diff, and use an empty changeset when there is no user-facing impact.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change