Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package {readr} to Imports in DESCRIPTION #31

Closed
huguesmp opened this issue Jan 27, 2023 · 4 comments · Fixed by #35
Closed

Add package {readr} to Imports in DESCRIPTION #31

huguesmp opened this issue Jan 27, 2023 · 4 comments · Fixed by #35
Assignees
Labels
documentation ✍️ Improvements or additions to documentation

Comments

@huguesmp
Copy link

Following instructions in the Readme, check_version() fails if readr is not installed.

image

@huguesmp
Copy link
Author

Also, I get a 404 after installing readr, but I'm new here, so problem could be a mistake on my part. Please ask if you need anything!

image

@judith-bourque
Copy link
Member

Also, I get a 404 after installing readr, but I'm new here, so problem could be a mistake on my part. Please ask if you need anything!

image

I've created #32 for this as it can be resolved independently from the original issue.

@judith-bourque judith-bourque self-assigned this Jan 27, 2023
@judith-bourque judith-bourque linked a pull request Jan 27, 2023 that will close this issue
@judith-bourque
Copy link
Member

@huguesmp Thanks for flagging these! 😄

They should be fixed. You can update your package by running

devtools::install_github("clessn/hublotr")

@huguesmp
Copy link
Author

All fixed, thanks!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ✍️ Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants