Added computation of best perfectWidth with kmeans algo #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@welcoMattic now that I managed to upgrade all dependencies to current versions (apart from There are many conflicts in package files, I'm not sure own to deal with this without breaking things. 😞 Thanks |
|
Hi @nhoizey, the branch is rebased. TBH, I don't remember very well how this works, but I fixed the tests. |
|
@welcoMattic thanks! 🙏 I'll try to check and test this week. |
|
@welcoMattic I just checked, I get a result that looks fine! 👍 I will merge the PR, as it will be at least a good start, and we'll be able to fine tune after. Thanks a lot, and sorry again for the way too long delay to merge this. 🙏 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to bring the computation of perfectWidth (= ideal image width depending on the viewport popularity) with k-means algo.
It seems working for a testing project, but I'm not 100% sure of this.
Ref #14