Enh helpers #450

Merged
merged 2 commits into from Apr 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

magefad commented Apr 9, 2013

Contributor

magefad commented Apr 9, 2013

Need import if use it.
For example in main.php import, add string to import:

'ext.bootstrap.helpers.*'

To be honest, I don't think it's a good idea to have a class defining 150 class constants which hide the CSS classes. CSS classes are documented in the Twitter Bootstrap and highly subject to changes. It was much better to allow users to specify icons by means of CSS class names and introduce a guard clause in the routine which will actually insert the icon to HTML. As it stands, TbIcon is a maintenance nightmare.

However, as it's for reasons of strange kind of compatibility... fuck it.

@hijarian hijarian added a commit that referenced this pull request Apr 9, 2013

@hijarian hijarian Merge pull request #450 from magefad/enh-helpers
Enh helpers
9247b66

@hijarian hijarian merged commit 9247b66 into clevertech:1.0.7-wip Apr 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment