Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to disable colour output #364

Open
arp242 opened this issue Feb 12, 2020 · 3 comments
Open

No way to disable colour output #364

arp242 opened this issue Feb 12, 2020 · 3 comments

Comments

@arp242
Copy link

@arp242 arp242 commented Feb 12, 2020

Changing the colour of text in terminals is tricky, because you never know what the background colour is, so the text may be unreadable or just look ugly. This is especially an issue with lighter backgrounds.

A -no-color switch or something to that would be useful. Right now I have to pipe stuff to cat to make the colours go away, which isn't very convenient.

@joshtriplett

This comment has been minimized.

Copy link

@joshtriplett joshtriplett commented Feb 12, 2020

@arp242 It's possible (albeit tricky) to detect whether the terminal has a light or dark background. Alternatively, there are a few colors that work well on both.

@zapo

This comment has been minimized.

Copy link

@zapo zapo commented Feb 19, 2020

Maybe something similar to ls --color flag would make sense like I suggested in #447 :

--color[=WHEN]
              colorize the output; WHEN can be 'always' (default if omitted), 'auto', or 'never'; more info below
@mislav

This comment has been minimized.

Copy link
Collaborator

@mislav mislav commented Feb 19, 2020

This is especially an issue with lighter backgrounds.

@arp242 Thank you for reporting! We would appreciate screenshots of low-readability of gh output in various terminal color configurations. (If the data is sensitive, you could run the same command against an open source repo.)

Git has excellent configurability regarding disabling/forcing/changing default colors— perhaps we should allow some configurability as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.