TestSearchIssues/displays_issues_and_pull_requests_tty fails in 2023

[bmwiedemann]

Describe the bug

While working on reproducible builds for openSUSE, I found that our gh-2.14.1 package stops building after 2023-03-04

Steps to reproduce the behavior

on openSUSE (or maybe Debian) do a package build with

osc co openSUSE:Factory/gh && cd $_
osc build --vm-type=kvm --noservice --clean --build-opt=--vm-custom-opt="-rtc base=2023-03-05T00:00:00" standard

Expected vs actual behavior

TestSearchIssues/displays_issues_and_pull_requests_tty fails after 2023-03-04, but tests should continue to work in future.

Logs

When building in 2038, I get

                                Diff:   
                                --- Expected
                                +++ Actual
                                @@ -3,4 +3,4 @@
                                
                                -issue  test/cli   #123  bug      bug, p1  about 1 year ago                     
                                -pr     what/what  #456  fix bug  fix      about 1 year ago                     
                                +issue  test/cli   #123  bug      bug, p1  about 17 years ago
                                +pr     what/what  #456  fix bug  fix      about 17 years ago   

                Test:           TestSearchIssues/displays_issues_and_pull_requests_tty
 FAIL

[mislav]

Thank you for the heads-up!

The problem is that TestSearchIssues uses absolute times in result stubs, but doesn't also stub time.Now()

cli/pkg/cmd/search/shared/shared.go

Line 122 in e2e8d69

now := time.Now()

As a result, relative time renderings such as about 1 year ago will keep changing as time goes on, eventually breaking the tests.