Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally read stdin for gh alias set #3490

Merged
merged 2 commits into from Apr 26, 2021
Merged

Optionally read stdin for gh alias set #3490

merged 2 commits into from Apr 26, 2021

Conversation

heaths
Copy link
Contributor

@heaths heaths commented Apr 22, 2021

Resolves #3487

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Apr 22, 2021
@heaths heaths mentioned this pull request Apr 22, 2021
Closed
@vilmibm vilmibm self-requested a review April 22, 2021 21:04
vilmibm
vilmibm suggested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

I would prefer that this trigger on -, though, as you originally suggested. While there's prior art in secret set I actually think secret set needs to change since we'd like it to prompt by default (and then have a flag for reading from STDIN).

@heaths
Copy link
Contributor Author

heaths commented Apr 23, 2021

I admit I also like how explicit - is.

@heaths
Copy link
Contributor Author

heaths commented Apr 23, 2021

While I'm at it, do you want me to change (or at least add - to) gh secret set for some consistency? For now to avoid backcompat breaks I can leave the optional last param. For now I'll just change what you requested, but down with "fixing" secret set as well if you want.

@heaths
Use - to read from stdin instead
aaa5a9e 
Resolves PR feedback.
@vilmibm
Copy link
Contributor

vilmibm commented Apr 26, 2021

@heaths thanks for the offer, but no worries. I've gone and tweaked secret set for better or worse.

vilmibm
vilmibm approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you~

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Apr 26, 2021
@vilmibm vilmibm merged commit ac0fe6b into cli:trunk Apr 26, 2021
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Apr 26, 2021
@heaths heaths deleted the issue3487 branch April 27, 2021 01:43
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilmibm vilmibm vilmibm approved these changes

Assignees

@vilmibm vilmibm

Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accept pipe input for gh alias set
2 participants
@heaths @vilmibm