Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Document `brew install gh` and that Homebrew works on Linux #400

Closed
wants to merge 1 commit into from

Conversation

@issyl0
Copy link

issyl0 commented Feb 13, 2020

  • Thanks for building this tool! <3
  • A contributor to Homebrew added gh to the Homebrew/homebrew-core
    tap, so I've replaced the third-party tap instructions with the
    standard ones.
  • Less to maintain for you, maybe?
  • Also, Homebrew works on Linux.
- Thanks for building this tool! <3
- A contributor to Homebrew added `gh` to the Homebrew/homebrew-core
  tap, so I've replaced the third-party tap instructions with the
  standard ones.
- Less to maintain for you, maybe?
- Also, Homebrew works on Linux.
@issyl0 issyl0 requested a review from mislav Feb 13, 2020
@billygriffin

This comment has been minimized.

Copy link
Contributor

billygriffin commented Feb 13, 2020

Hi @issyl0, thank you and we definitely want to do this sooner rather than later. We were discussing yesterday whether we want to have automation in place to ensure any of our releases also get propagated to homebrew, so we may try to figure that out first before merging this.

@issyl0

This comment has been minimized.

Copy link
Author

issyl0 commented Feb 13, 2020

Totally, makes sense! Given @mislav is involved you probably already know about https://github.com/mislav/bump-homebrew-formula-action, and it seems to work well if you wanted to go that way.

@sjackman

This comment has been minimized.

Copy link

sjackman commented Feb 13, 2020

I'd be quite excited to see more upstream maintainers adopt https://github.com/mislav/bump-homebrew-formula-action!

@vilmibm

This comment has been minimized.

Copy link
Collaborator

vilmibm commented Feb 13, 2020

we were using it ^_^ 7a1ae75 then we consolidated to use goreleaser.

We didn't expect to be in homebrew core so soon so we're kind of catching up to that -- we were initially under the impression gh wouldn't be accepted until it was out of beta.

@issyl0 issyl0 removed the request for review from mislav Feb 13, 2020
@mislav

This comment has been minimized.

Copy link
Collaborator

mislav commented Feb 17, 2020

Hi @issyl0, thank you so much for the suggestion!

For the reasons mentioned above and because there are some subtle issues with gh formula as it currently appears in homebrew-core, we won't be changing our installation instructions right now. When we do in the future, we'll also put some mechanism in place to automatically bump the gh formula on releases, like you suggested.

We will also make it clear that Homebrew install instructions apply to Linux users, too. 👍

@mislav mislav closed this Feb 17, 2020
@issyl0

This comment has been minimized.

Copy link
Author

issyl0 commented Feb 17, 2020

Thanks for the reply. I'd be interested in knowing what the "subtle issues" are, if you have time, so we can fix them.

@mislav

This comment has been minimized.

Copy link
Collaborator

mislav commented Feb 17, 2020

@issyl0

  1. These lines of brew test gh are brittle and likely to fail with future releases of gh, but I see now that they have been removed after that PR.

  2. Because it's built from source, GitHub CLI as installed via homebrew-core formula will use the “GitHub CLI (dev)” OAuth app whereas official binaries (and the formula from our tap) are configured to use “GitHub CLI” which has better privileges. #401 (comment)

@issyl0 issyl0 deleted the issyl0:readme-homebrew-core-tap branch Feb 17, 2020
issyl0 added a commit to issyl0/homebrew-core that referenced this pull request Feb 17, 2020
- It turns out that this isn't entirely open source.
- Building from source here uses the GitHub CLI (dev) OAuth token,
  whereas the one from the third-party `github/homebrew-gh` tap has full
  permissions. The formulae in that tap install binaries directly.
- We shouldn't be shipping sub-optimal software, and we can't change any
  of this behaviour.
- See cli/cli#400 for further context.
@issyl0 issyl0 mentioned this pull request Feb 17, 2020
5 of 5 tasks complete
@issyl0

This comment has been minimized.

Copy link
Author

issyl0 commented Feb 17, 2020

Based on those comments, especially the OAuth app one, it's better off staying in your tap then as binaries. Thanks for the explanation! I've made a PR to remove it from Homebrew/homebrew-core.

issyl0 added a commit to issyl0/homebrew-core that referenced this pull request Feb 17, 2020
- Building from source here uses the GitHub CLI (dev) OAuth token,
  whereas the one from the third-party `github/homebrew-gh` tap has full
  permissions. The formulae in that tap install binaries directly.
- We shouldn't be shipping sub-optimal software, and we can't change any
  of this behaviour ourselves.
- See cli/cli#400 for further context.
issyl0 added a commit to Homebrew/homebrew-core that referenced this pull request Feb 17, 2020
- Building from source here uses the GitHub CLI (dev) OAuth token,
  whereas the one from the third-party `github/homebrew-gh` tap has full
  permissions. The formulae in that tap install binaries directly.
- We shouldn't be shipping sub-optimal software, and we can't change any
  of this behaviour ourselves.
- See cli/cli#400 for further context.
@zbeekman

This comment has been minimized.

Copy link

zbeekman commented Feb 17, 2020

Somewhat off topic: I was working on a homebrew-bump-formula-pr action, but I'm very grateful someone more qualified and talented than myself (@mislav) beat me to a functioning product! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.