-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inconsistent format between issue list and status #532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just few little suggestions, plus a request: since this tweaks the output of issue status
, could you apply the same improvements to pr status
?
Thanks! This looks great ✨
PR status has optional |
Hmm that's a good point. Right now it might be tricky to force those into table fields. Please disregard my last comment and hold off porting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good if we just consider issue status
output, but I would hold off merging until we figure out whether it's a problem that this makes the output different than pr status
, and discuss how could we apply the same formatter there—PR status has more fields, so it might be more complicated to force it to a table layout.
Yap. I'm glad that this pr is approved :) I'll be waiting for final decisions. |
I think since the info and layout of pr status is more complex we shouldn’t force the table layout. So I think this is good to go! |
Currently,
issue list
andissue status
have different printing formats.This PR adds the
age
section forissue list
and uses thetablewriter
forissue status
to keep the format consistency between them.Current version
Fixed version