Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release of 1.0] Check for FALL maps to concepticon in all datasets #27

Closed
LinguList opened this issue Jun 28, 2018 · 14 comments
Closed
Assignees

Comments

@LinguList
Copy link
Contributor

Some datasets have a strange bias linking "fall" in the meaning of "autumn" to "fall = descend"! I suspect TLS, Bowern's data, and maybe some other datasets. Sun1991 as well. But it is very strange... So please all data maintainers, quickly check whether this is normal. Check for the auto-produced subgraph for "summer" for referenceof this error.

@xrotwang
Copy link
Collaborator

Here are all datasets that have AUTUMN at all:

$ grep 1276 */cldf/parameters.csv
cals/cldf/parameters.csv:autumn,autumn,1276,AUTUMN
ids/cldf/parameters.csv:14-770,autumn,1276,AUTUMN
northeuralex/cldf/parameters.csv:HerbstN,Herbst::N,1276,
suntb/cldf/parameters.csv:autumn,autumn,1276,AUTUMN
tls/cldf/parameters.csv:fall,fall,1276,AUTUMN,
wold/cldf/parameters.csv:14-77,the autumn/fall,1276,AUTUMN

@LinguList
Copy link
Contributor Author

It looks like it's only TLS, as this should be linked to "fall" = descend (or not, @tresoldi ?). Strangely, I find this only in the app, not in the SQLITE, so the creation of the app still seems to be extremely buggy...

@LinguList
Copy link
Contributor Author

Or I was just not paying attention to another step for the standalone app creation ?

@xrotwang
Copy link
Collaborator

Hm. Must be the graph creation, already, I'd say.

@xrotwang
Copy link
Collaborator

I'm seeing the same thing, only in the subgraph, though.

@LinguList
Copy link
Contributor Author

I'm re-running the code for subgraph now. Maybe it's just a problem of syncing. The numbers are also wrong, showing some 1417 words linked for "fall" and "autumn".

bildschirmfoto_2018-06-28_12-25-12

@xrotwang
Copy link
Collaborator

No, it seems already db loading is buggy:

sqlite> select distinct f.dataset_ID from formtable as f, parametertable as p where f.parameter_id = p.id and p.concepticon_id = '1276';
lexibank-bowernpny
lexibank-ids
lexibank-northeuralex
lexibank-satterthwaitetb
lexibank-suntb
lexibank-tls
lexibank-tryonsolomon
lexibank-wold

@xrotwang
Copy link
Collaborator

datasets are loaded with forms for AUTUMN, even though the datasets doesn't have AUTUMN in its parameters.csv.

@xrotwang
Copy link
Collaborator

Hm. that's a bit scary. I'm investigating.

@xrotwang
Copy link
Collaborator

Ok, Not as scary, hopefully:

sqlite> select distinct f.dataset_ID from formtable as f, parametertable as p where f.parameter_id = p.id and f.dataset_id = p.dataset_id and p.concepticon_id = '1276';
lexibank-ids
lexibank-northeuralex
lexibank-suntb
lexibank-tls
lexibank-wold

So maybe this is just a buggy db query in pyclics, which doesn't take into account that we always have composite primary keys (id, dataset_id) in the db. (See @SimonGreenhill - it's not easy)

Will investigate after lunch.

@LinguList
Copy link
Contributor Author

Okay, relieved this is NOT the data! I was getting scared...

@xrotwang
Copy link
Collaborator

xrotwang commented Jun 28, 2018 via email

@xrotwang
Copy link
Collaborator

All good again: 6c41d5d#diff-f98b9409af68c1f168b8712d59d026d8

@xrotwang
Copy link
Collaborator

screenshot from 2018-06-28 15-59-47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants