Making dynamic library build on mac os #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld -shared doesn't work on mac os, ld -dynamic would work better but it seems simpler to just use CC to build it
|
Any chance to get this merged in ? |
|
honestly, i am not fun to put the libinjection in to shared object due to variety reasons. It is better to leave it as an option instead of default option. |
|
Is that really what it does ? Seems like the changes are just about fixing something that is broken on mac os. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ld -shared doesn't work on mac os, ld -dynamic would work better
but it seems simpler to just use CC to build it
This would need to be tested on Linux (or the original target arch).