Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No rule called notEmpty #29

Closed
sthaha opened this issue Aug 26, 2014 · 4 comments
Closed

No rule called notEmpty #29

sthaha opened this issue Aug 26, 2014 · 4 comments

Comments

@sthaha
Copy link

sthaha commented Aug 26, 2014

It seems validator has removed all the negative validators - notNull and notEmpty
so a command like nestor console job_name fails with the following error:


~/.nvm/v0.10.30/lib/node_modules/nestor/node_modules/bagofcli/lib/bagofcli.js:112
      if (validator[rule](arg) === false) {
                         ^
TypeError: Property 'notEmpty' of object  is not a function
    at ~/.nvm/v0.10.30/lib/node_modules/nestor/node_modules/bagofcli/lib/bagofcli.js:112:26
    at Array.forEach (native)
    at _postCommand (~/.nvm/v0.10.30/lib/node_modules/nestor/node_modules/bagofcli/lib/bagofcli.js:151:34)
    at Object.command (~/.nvm/v0.10.30/lib/node_modules/nestor/node_modules/bagofcli/lib/bagofcli.js:68:3)
    at Object.exec (~/.nvm/v0.10.30/lib/node_modules/nestor/lib/cli.js:311:7)
    at Object.<anonymous> (~/.nvm/v0.10.30/lib/node_modules/nestor/bin/nestor:4:5)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)

@cliffano
Copy link
Owner

Thanks for reporting this, I will fix bagofcli.
On Nestor's end, I will add some integration tests for some commands.

cliffano added a commit that referenced this issue Aug 28, 2014
@marblegravy
Copy link

Just confirming that the fix you made to bagofcli at cliffano/bagofcli#6 does resolve this issue. Thanks!

@sthaha
Copy link
Author

sthaha commented Aug 29, 2014

I have also verified that your fix resolves the issue. @cliffano thank you.

@sthaha sthaha closed this as completed Aug 29, 2014
@cliffano
Copy link
Owner

Thanks again @sthaha for reporting the error, and @marblegravy for taking the time to confirm.
Much appreciated, folks :).
+1 for community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants