Implement Jenkins#consoleStream #11

Merged
merged 1 commit into from Apr 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

5long commented Mar 31, 2013

This branch is just #10 and:

  • rebased against master branch
  • squashed into a single commit
Owner

cliffano commented Apr 2, 2013

Looks good at a glance. I'm going to test it against my common usage scenarios first.

@cliffano cliffano added a commit that referenced this pull request Apr 2, 2013

@cliffano cliffano Merge pull request #11 from 5long/console-stream-squashed
Implement Jenkins#consoleStream
298a6f9

@cliffano cliffano merged commit 298a6f9 into cliffano:master Apr 2, 2013

1 check passed

default The Travis build passed
Details
Owner

cliffano commented Apr 5, 2013

Thanks for the contribution Whyme. This change has been included in v0.1.2 .

Owner

cliffano commented Apr 7, 2013

Hmm, I just tested the new console handling a bit more and I noticed that it no longer behaves as it was originally designed.

The intention was to simulate console output display on the terminal the same way as the console output is displayed on Jenkins web, i.e. it should progress along the build.

Contributor

5long commented Apr 8, 2013

I'm using nestor console to monitor our deploy job and it works as intended. A moment before I've tested nestor console with a lengthy frontend assets compiling job and it works too. By "it works" I mean nestor console and <jenkins url>/job/<job name>/<job id>/console are printing output as the same pace.

What is the pattern of your job output? Is it a dot matrix of unit test result which doesn't print any \n for a long time? I'm suspecting that the stdout of node is buffered line-wise but I'm not quite sure.

I'll do more testing against more jobs and see if I can reproduce it.

Also, I'm running nodejs 0.8.22, nestor 0.1.3 and Jenkins 1.480.3 LTS.

Contributor

5long commented Apr 8, 2013

Well it turns out that I guessed wrong. process.stdout.write is synced by default when stdout is TTY: http://nodejs.org/api/process.html#process_process_stdout

Owner

cliffano commented Apr 8, 2013

Weird, I can't reproduce the problem now. What I saw was tty console output being written without new lines and at a different pace compared to web console output. I used node v0.10.1 .

Don't worry about it. I'll do more testing, but I think it was a false alarm.

Thanks for the confirmation.

5long deleted the 5long:console-stream-squashed branch Apr 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment