Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change free surface displacement name from η to displacement for HydrostaticFreeSurfaceModel #3702

Open
glwagner opened this issue Aug 13, 2024 · 1 comment
Open

Change free surface displacement name from η to displacement for HydrostaticFreeSurfaceModel #3702

glwagner opened this issue Aug 13, 2024 · 1 comment
Labels
abstractions 🎨 Whatever that means user interface/experience 💻

Comments

@glwagner
Copy link
Member

I think it reads better in a script / produces scripts that are more understandable because instead of

η = model.free_surface.η

we would read

η = model.free_surface.displacement
@glwagner glwagner changed the title Change free surface displacement name from η to displacement for `HydrostaticFreeSurfaceModel Change free surface displacement name from η to displacement for HydrostaticFreeSurfaceModel Aug 13, 2024
@navidcy
Copy link
Collaborator

navidcy commented Aug 24, 2024 •
edited
Loading

I really like this also!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
abstractions 🎨 Whatever that means user interface/experience 💻
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@navidcy @glwagner