has_changed for nested objects! #28

Merged
merged 3 commits into from Jan 4, 2013

Conversation

Projects
None yet
2 participants
@amiri
Contributor

amiri commented Dec 9, 2012

The serializer passes the serialized string as the "array ref" to be inflated! I changed this, perhaps somewhat crudely, but the test makes clear what I mean. It's a pretty important feature, though, I think.

@clintongormley clintongormley merged commit b4e47d5 into clintongormley:master Jan 4, 2013

1 check failed

default The Travis build failed
Details
@clintongormley

This comment has been minimized.

Show comment Hide comment
@clintongormley

clintongormley Jan 4, 2013

Owner

Hi @amiri

The problem was a bit different - didn't apply just to nested types. has_changed was comparing any reference as a JSON string, but then trying to inflate the original value from that string, instead of from the original "json-friendly" data structure.

This is now fixed and will be released in the new version. Thanks for reporting it

clint

Owner

clintongormley commented Jan 4, 2013

Hi @amiri

The problem was a bit different - didn't apply just to nested types. has_changed was comparing any reference as a JSON string, but then trying to inflate the original value from that string, instead of from the original "json-friendly" data structure.

This is now fixed and will be released in the new version. Thanks for reporting it

clint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment