Christopher Lin clizzin

clizzin pushed to master at airbnb/ruby
@clizzin
clizzin merged pull request airbnb/ruby#46
@clizzin
"intented" => "intended"
1 commit with 1 addition and 1 deletion
clizzin commented on pull request airbnb/ruby#46
@clizzin

Thanks!

clizzin pushed to master at airbnb/ruby
@clizzin
clizzin merged pull request airbnb/ruby#45
@clizzin
Use bang, not not.
1 commit with 1 addition and 1 deletion
clizzin commented on pull request airbnb/ruby#45
@clizzin

Looks good to me.

clizzin commented on pull request airbnb/ruby#44
@clizzin

@fengmingAirbnb I think you misunderstand the guideline. The guideline does not advise against use of return to return a value early in the method …

clizzin pushed to master at airbnb/ruby
@clizzin
clizzin merged pull request airbnb/ruby#39
@clizzin
Corrected parameter & argument misnomers
2 commits with 5 additions and 5 deletions
clizzin commented on pull request airbnb/ruby#39
@clizzin

Great, thanks!

clizzin pushed to master at airbnb/ruby
@clizzin
clizzin merged pull request airbnb/ruby#42
@clizzin
Add indentation rule for multi-line boolean expression
1 commit with 18 additions and 0 deletions
clizzin commented on pull request airbnb/ruby#42
@clizzin

Sounds like we have consensus that this guideline is good, so merging. Thanks for contributing!

clizzin closed pull request airbnb/ruby#44
@clizzin
Make an explicit return in Ruby
clizzin commented on pull request airbnb/ruby#44
@clizzin

Okay, seems like there's enough consensus on sticking to the current guideline that we should stick with it. Thanks for participating in the discus…

clizzin commented on pull request airbnb/ruby#44
@clizzin

Seems like there's consensus that we shouldn't require explicit return statements. I am of this mind as well. Gary's latest comment raises a new qu…

clizzin commented on pull request airbnb/ruby#44
@clizzin

Although people generally don't like the advice to explicitly return values at the end of a method, I do think this advice on yield vs. return is u…

clizzin closed pull request airbnb/ruby#43
@clizzin
fix a condition style
clizzin commented on pull request airbnb/ruby#43
@clizzin

I agree with Brian that the right choice between !(foo? && bar?) and !foo? || !bar? is highly dependent on the context of the code, and what the ex…

clizzin created branch foobar at clizzin/nsync
clizzin pushed to master at airbnb/ruby
@clizzin
clizzin merged pull request airbnb/ruby#41
@clizzin
Fix "bad" version of do-end example.
1 commit with 1 addition and 3 deletions
clizzin commented on pull request airbnb/ruby#41
@clizzin

:+1: Thanks!

clizzin commented on pull request airbnb/ruby#40
@clizzin

Good catch. Can we add an additional revision to make it look like this: **Omit parentheses** for a method call: * If the method accepts no argumen…

clizzin commented on pull request airbnb/smartstack-cookbook#10
@clizzin

Ah, I don't have write access to this repository. @igor47 Can you merge this? It only makes copy changes, and I've reviewed them all.

clizzin commented on pull request airbnb/smartstack-cookbook#10
@clizzin

:+1: Thanks!

clizzin commented on pull request airbnb/ruby#39
@clizzin

Thanks for the contribution! I'm not personally strict about proper usage of these terms since it's easy to understand what people mean even if the…

clizzin commented on pull request airbnb/ruby#39
@clizzin

In this case, we really do mean to use "arguments," not "parameters."

clizzin commented on pull request airbnb/synapse#100
@clizzin

Sorry @Jaykah, the project maintainer @igor47 is really busy with other projects for Airbnb these days. We're doing our best to find time to respon…

clizzin commented on pull request airbnb/synapse#58
@clizzin

Sorry folks, the project maintainer @igor47 is really busy with other projects for Airbnb these days. We're doing our best to find time to respond …