Fix websocket-upgrade-request? for Firefox WebSocket upgrade requests. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot xorgy. Could you please also provide a test which shows that this doesn't break existing functionality, ie that it works when only sending "Upgrade" in the connection header, as well as when sending "keep-alive,Upgrade"? |
Sure, I'll write a test for it. Probably good to have one anyway, given that there are zero tests for this function right now. |
|
Let me know if the test I've added is satisfactory, I can squash it in. |
slipset
approved these changes
Jan 13, 2021
|
Thank you as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #561