From 24ff7fd6ea75c97ea8476f82fba3c6345a941b27 Mon Sep 17 00:00:00 2001 From: Bjarte Johansen Date: Thu, 20 Sep 2012 12:06:49 +0200 Subject: [PATCH] Remove do binding in let form do binding in let form is not neccessary as let provides an implicit do form. --- src/kibit/rules/control_structures.clj | 2 +- test/kibit/test/control_structures.clj | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/kibit/rules/control_structures.clj b/src/kibit/rules/control_structures.clj index 4c43920..2c3e8d9 100644 --- a/src/kibit/rules/control_structures.clj +++ b/src/kibit/rules/control_structures.clj @@ -18,7 +18,7 @@ ;; suggest `while` for bindingless loop-recur [(loop [] (when ?test . ?exprs (recur))) (while ?test . ?exprs)] - ) + [(let ?binding (do . ?exprs)) (let ?binding . ?exprs)]) (comment (when (not (pred? x y)) (f x y)) diff --git a/test/kibit/test/control_structures.clj b/test/kibit/test/control_structures.clj index 6b68bb6..a8d5712 100644 --- a/test/kibit/test/control_structures.clj +++ b/test/kibit/test/control_structures.clj @@ -16,4 +16,5 @@ 'single-expression '(do single-expression) '_ '(when-not true anything) '_ '(when false anything) - '(when-let [a test] expr) '(if-let [a test] expr nil))) + '(when-let [a test] expr) '(if-let [a test] expr nil) + '(let [a 1] (println a) a) '(let [a 1] (do (println a) a))))