Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-52 (specify python executable) #53

Merged
merged 3 commits into from Jan 21, 2020

Conversation

jjtolton
Copy link
Contributor

@jjtolton jjtolton commented Jan 20, 2020

Closes: #52

Usage:

(py/initialize! :python-executable "python3.7") ;; works
(py/initialize! :python-executable "path/to/virtual/env/python") ;; works
(py/initialize!) ;; works

@cnuernber
Copy link
Collaborator

@cnuernber cnuernber commented Jan 20, 2020

This is a solid improvement.

Do we want the python executable to be specified via an environment variable like PYTHON_EXECUTABLE?

@cnuernber
Copy link
Collaborator

@cnuernber cnuernber commented Jan 20, 2020

I merged the simplification and now there are conflicts with this PR, sorry!

@jjtolton
Copy link
Contributor Author

@jjtolton jjtolton commented Jan 21, 2020

No problem, I'll take care of it. Regarding the env var, I think we should make that an option too, but local :bind-ns should override PYTHON_EXECUTABLE

@jjtolton
Copy link
Contributor Author

@jjtolton jjtolton commented Jan 21, 2020

I was also thinking a python.edn might be a good place to put that info. Is it alright if we handle those in separate PRs?

@cnuernber cnuernber merged commit c17c7a0 into clj-python:master Jan 21, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants