Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark external links as rel="nofollow" #192

Closed
danielcompton opened this issue Oct 31, 2018 · 1 comment
Closed

Mark external links as rel="nofollow" #192

danielcompton opened this issue Oct 31, 2018 · 1 comment

Comments

@danielcompton
Copy link
Contributor

@danielcompton danielcompton commented Oct 31, 2018

Similarly to #190, GitHub marks all external links in issues and markdown documents as rel="nofollow".Despite the name, this doesn't stop Google from following the link, it just doesn't let that link pass any ranking power to the linked site. Many other sites that use community generated content like Stack Overflow do similar things. Given that you're running a site where anyone can get something published, I think this would be a good precaution to take to ensure that cljdoc doesn't become an attractive target for spammers.

samihda added a commit to samihda/cljdoc that referenced this issue Jan 8, 2019
samihda added a commit to samihda/cljdoc that referenced this issue Jan 10, 2019
samihda added a commit to samihda/cljdoc that referenced this issue Jan 11, 2019
Previously, the attribute was added before the links were fixed,
so the newly-generated external links still didn’t have the attribute.

Related: cljdoc#192
martinklepsch added a commit that referenced this issue Jan 13, 2019
Previously, the attribute was added before the links were fixed,
so the newly-generated external links still didn’t have the attribute.

Related: #192
@martinklepsch

This comment has been minimized.

Copy link
Member

@martinklepsch martinklepsch commented Jan 13, 2019

Closed via #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.