Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand quick switcher to also search in projects functions/articles #194

Open
martinklepsch opened this issue Nov 2, 2018 · 0 comments
Open
Labels

Comments

@martinklepsch
Copy link
Member

@martinklepsch martinklepsch commented Nov 2, 2018

We have this quick switcher and I think it would be really amazing if it could also work to search inside a project.

To do this the following would be necessary:

  • Provide some JSON "table of contents" to the JS-based search. This could be an XHR request or embedded into the page when it's rendered. (This would be similar to the quick switcher which retrieves candidates from local storage.)
  • Establish a second state for the quick switcher that is "scoped" to the current project. I imagine that this being the default when bringing it up. Perhaps you could get to the global state by hitting backspace while the input is empty.

I've seen examples of this in the wild but can't find something immediately. I'll eventually add a mockup to this issue.

By having clear scoping we avoid the issue of global search (for now) and only offer two specific modes:

  • global search (results are artifacts)
  • local search (results are namespaces, functions, articles, ...)

... which I think is a good compromise and covers the most common usage patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.