Add Transitions with :indefinite examples #31

frenchy64 · 2019-07-12T23:19:15Z

Based on the feedback of #30, this PR adds support for JavaFX transitions.

The example demonstrates all transitions using :indefinite cycles. I haven't tried transitions that are more responsive, and we should probably try them before merging this.

Example gif

vlaaad

Good stuff! There are some minor issues I want to see adressed first, then I'd be happy to merge it.

vlaaad · 2019-07-13T11:35:56Z

src/cljfx/fx/animation.clj

+    :on-cycle-duration-changed [:property-change-listener lifecycle/change-listener]
+    :delay [:setter lifecycle/scalar :coerce coerce/duration :default 0]
+    :on-delay-changed [:property-change-listener lifecycle/change-listener]
+    :on-finished [:setter lifecycle/event-handler :coerce coerce/event-handler :default nil]


:default nil is default behavior, no need to specify it. What's more problematic, is that presence of :default will make it go through coerce function, and nil is not a valid input to coerce/event-handler. Removing default will assign nil to finished event handler, which is what we want.

vlaaad · 2019-07-13T11:38:08Z

src/cljfx/fx/animation.clj

+    :auto-reverse [:setter lifecycle/scalar :default false]
+    :on-auto-reverse-changed [:property-change-listener lifecycle/change-listener]
+    :on-current-time-changed [:property-change-listener lifecycle/change-listener]
+    :cycle-count [:setter lifecycle/scalar :coerce coerce/animation :default 1.0]


cycle count is int, I know it's coerced to int, but I think default should also be int to make clear.

Yes, in this case the javadoc for Animation was wrong.

vlaaad · 2019-07-13T11:49:47Z

src/cljfx/fx/animation.clj

+              :coerce #(if (string? %)
+                         %
+                         (coerce/duration %))]
+    :on-status-changed [:property-change-listener lifecycle/change-listener]


:on-status-changed will receive enum like Animation$Status/STOPPED. I'm not sure whether I want to receive it or keyword :stopped... From one hand, it's nice to have same values for :status and :on-status-changed, like we have :text and :on-text-changed for text field. On the other hand, cljfx does no preprocessing for events, and I find it valuable to have KeyEvents themselves in event handlers, because they have useful information. Although, enum is no better than keyword, and there is no additional information in this case.

What do you think?

I think a preprocessed event could be added to another :fx/* key other than :fx/event, but this seems consistent with the rest of cljfx, if ugly.

vlaaad · 2019-07-13T11:53:47Z

src/cljfx/fx/fade_transition.clj

+      :duration [:setter lifecycle/scalar :coerce coerce/duration :default 400]
+      :from-value [:setter lifecycle/scalar :coerce double :default ##NaN]
+      :to-value [:setter lifecycle/scalar :coerce double :default ##NaN]
+      :by-value [:setter lifecycle/scalar :coerce double])))


:by-value should have :default 0

vlaaad · 2019-07-13T12:00:10Z

src/cljfx/fx/fill_transition.clj

+      :shape [:setter lifecycle/dynamic]
+      :duration [:setter lifecycle/scalar :coerce coerce/duration :default 400]
+      :from-value [:setter lifecycle/scalar :coerce coerce/color :default nil]
+      :to-value [:setter lifecycle/scalar :coerce coerce/color :default nil])))


should remove :defaults: nil is not a valid input for coerce/color

vlaaad · 2019-07-13T12:16:03Z

src/cljfx/coerce.clj

+    (= :indefinite x) Animation/INDEFINITE
+    :else (int x)))
+
+(defn interpolator [x]


should be moved to cljfx.fx.transition

vlaaad · 2019-07-13T12:16:27Z

src/cljfx/coerce.clj

+(defn animation [x]
+  (cond
+    (= :indefinite x) Animation/INDEFINITE
+    :else (int x)))


should be moved to cljfx.fx.animation

vlaaad · 2019-07-13T12:16:49Z

src/cljfx/coerce.clj

+            :linear Interpolator/LINEAR
+            (fail Interpolator x))))
+
+(defn path-transition-orientation [x]


should be moved to cljfx.fx.path-transition

Replaced with coerce/enum.

vlaaad · 2019-07-13T12:20:49Z

examples/e31_indefinite_transitions.clj

+                                    {:fx/type view
+                                     :state state}))))
+
+(fx/mount-renderer *state renderer)


I noticed you don't use state at all, in that case there is no need to introduce state/renderer in example, just use fx/create-component:

(fx/on-fx-thread (fx/create-component {:fx/type :stage :showing true :always-on-top true :width 600 :height 500 :scene {:fx/type :scene :root {:fx/type on-grid :rows 5 :columns 2 :children (mapv (fn [[header transition]] (with-header header {:fx/type start-transition-on :transition transition ; run each animation on a small rectangle :desc {:fx/type :rectangle :width 20 :height 50}})) indefinite-animations)}}}))

Moved the state stuff to a comment; I think it's always nice to be able to use state to play with the examples.

vlaaad · 2019-07-13T12:22:09Z

src/cljfx/fx/translate_transition.clj

+                   :playing (.play ^TranslateTransition %1)
+                   :stopped (.stop ^TranslateTransition %1)))
+              lifecycle/scalar
+              :default :stopped])))


:state is covered by :status, there is no need for such prop, right?

frenchy64 · 2019-07-25T13:09:24Z

I've addressed all the changes, I'll let you resolve the change requests. Thanks for your time!

vlaaad · 2019-07-27T16:54:05Z

Thanks!

add transitions

edc50ab

vlaaad requested changes Jul 13, 2019

View reviewed changes

requested changes for cljfx#31

9fa71bb

vlaaad merged commit 9fa71bb into cljfx:master Jul 27, 2019

frenchy64 mentioned this pull request Sep 25, 2019

RFC: Basic Animation #30

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Transitions with :indefinite examples #31

Add Transitions with :indefinite examples #31

frenchy64 commented Jul 12, 2019 •

edited

Loading

vlaaad left a comment

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 13, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

vlaaad Jul 13, 2019

frenchy64 Jul 25, 2019

frenchy64 commented Jul 25, 2019

vlaaad commented Jul 27, 2019

Add Transitions with :indefinite examples #31

Add Transitions with :indefinite examples #31

Conversation

frenchy64 commented Jul 12, 2019 • edited Loading

vlaaad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frenchy64 commented Jul 25, 2019

vlaaad commented Jul 27, 2019

frenchy64 commented Jul 12, 2019 •

edited

Loading