Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New price extraction engine, expired rates are removed #21

Merged
merged 53 commits into from Oct 2, 2019

Conversation

@cljoly
Copy link
Owner

commented Oct 2, 2019

A new engine now recognize price in plain text for numerous scenario.

Outdated rates are now automatically deleted.

Clément Joly added 30 commits Sep 22, 2019
Clément Joly
Clément Joly
Clément Joly
Clément Joly
Clément Joly
- When the iter_from function was panicking on key that did not exist,
we used iterator over every key in the database as a work around.
Now that iter_from is working as expected (go to the first key after
the one given), we can improve performance using it. It would also offer
room to add functionnalities.
Clément Joly added 23 commits Sep 28, 2019
Clément Joly
Results:
test db::rate::tests::bench_key_extract_db::bench_create_data_current_impl          ... bench:         194 ns/iter (+/- 8)
test db::rate::tests::bench_key_extract_db::bench_create_data_null_split            ... bench:         193 ns/iter (+/- 8)
test db::rate::tests::bench_key_extract_db::bench_create_data_null_split_array_join ... bench:         103 ns/iter (+/- 3)
test db::rate::tests::bench_key_extract_db::bench_create_data_regex                 ... bench:         194 ns/iter (+/- 8)
test db::rate::tests::bench_key_extract_db::bench_extract_data_current_impl         ... bench:       1,426 ns/iter (+/- 57)
test db::rate::tests::bench_key_extract_db::bench_extract_data_null_split           ... bench:         410 ns/iter (+/- 14)
test db::rate::tests::bench_key_extract_db::bench_extract_data_regex                ... bench:       1,427 ns/iter (+/- 68)
Clément Joly
Clément Joly
Clément Joly
Clément Joly
Clément Joly
Clément Joly
Clément Joly
Clément Joly
Clément Joly
@cljoly cljoly merged commit 99ed337 into master Oct 2, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.