Add option to topic to not notify local queues when publishing events #2

Merged
merged 3 commits into from Feb 2, 2012

Conversation

Projects
None yet
2 participants
@revmischa
Contributor

revmischa commented Nov 1, 2011

ZeroMQ doesn't want to automatically append events to local listeners when calling ->publish(). This additional optional allows the code to stay clean without changing any existing interfaces.

Much better: revmischa/anymq-zeromq@abe29d0

Also as a result, my pubsub hippie middleware can fully use AnyMQ instead of relying on AnyMQ::ZeroMQ-specific behavior

@clkao

This comment has been minimized.

Show comment Hide comment
@clkao

clkao Nov 2, 2011

Owner

Hi,

Can you add a test case for this patch?

Owner

clkao commented Nov 2, 2011

Hi,

Can you add a test case for this patch?

@revmischa

This comment has been minimized.

Show comment Hide comment
@revmischa

revmischa Nov 2, 2011

Contributor

Test case is in commit 13f5493 in AnyMQ::ZeroMQ. Test fails if publish_to_queues is true for ZeroMQ

Contributor

revmischa commented Nov 2, 2011

Test case is in commit 13f5493 in AnyMQ::ZeroMQ. Test fails if publish_to_queues is true for ZeroMQ

@revmischa

This comment has been minimized.

Show comment Hide comment
@revmischa

revmischa Nov 4, 2011

Contributor

Test case attached

Contributor

revmischa commented Nov 4, 2011

Test case attached

@revmischa

This comment has been minimized.

Show comment Hide comment
@revmischa

revmischa Jan 11, 2012

Contributor

Is this chill? Are you waiting on anything from me?

Contributor

revmischa commented Jan 11, 2012

Is this chill? Are you waiting on anything from me?

clkao added a commit that referenced this pull request Feb 2, 2012

@clkao clkao merged commit cc1c94e into clkao:master Feb 2, 2012

@clkao

This comment has been minimized.

Show comment Hide comment
@clkao

clkao Feb 2, 2012

Owner

merged, thanks!

Owner

clkao commented Feb 2, 2012

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment