Feature/up ncp limit #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microadam Please QA and let me know, when or how this needs to be deployed. |
|
@serby Thanks a lot for this! checked out the branch and there are a few lint errors. Assuming your editor didn't pick them up? Tests pass though and code looks fine otherwise. I will leave you to fix the lint errors so you can make sure your editor is definitely configured correctly. In terms of deployment, will need to update the ansible role with the new version of this package (once published) and then run it on whatever platform you wish to have it on for immediate testing |
microadam
reviewed
Oct 24, 2016
| @@ -1,13 +1,15 @@ | |||
| { "excludeFiles": | |||
| [ "node_modules/**" | |||
| , "coverage" | |||
| , "site/themes/*/assets/js" | |||
There was a problem hiding this comment.
@serby could we remove these ignores please? not really applicable here
added 2 commits
October 24, 2016 10:23
|
Good spot. Done and done. |
|
ShortList, RIBA and Localworld |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeding up NCP