New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference between CDN and clojars.org/repo #707
Comments
Hmm, this is definitely a bug, the two repositories should show the same files (though they are pointing to two different locations, so getting out of sync like this is possible). |
Agreed. And it is an odd one - we write to the cloudfiles repo here: https://github.com/clojars/clojars-web/tree/master/src/clojars/routes/repo.clj#L271, then write the jar to the db here: https://github.com/clojars/clojars-web/tree/master/src/clojars/routes/repo.clj#L278, so if the cloudfile write fails, it should never reach the db write. But 0.1.4 and 0.1.4-SNAPSHOT exist in the db, since they show on https://clojars.org/ivarref/datomic-schema/versions/0.1.4 |
I scanned all of the jars + poms on disk and checked them against the CDN. The following 17 were missing from cloudfiles (though trying to load the
|
I have discovered another difference that could be blocking technomancy/leiningen#2581. Maven metadata files served at
|
Ah, now they are there. Apparently it takes a few minutes until the changes appear in repo.clojars.org. Apologies for the noise! |
@glts correct - there is a 15 minute TTL on the CDN, so changed files may take up to that time to appear in |
I believe this is caused by failures in our code that uploads to cloudfiles asynchronously. I'm working on changing the deploy logic to upload synchronously instead, so if uploading fails, the deployment will fail. That should prevent this from happening in the future. I also uploaded any files that were missing from or had an incorrect checksum in the cloudfiles repo (treating the on-disk repo as the canonical source) last week. I'll run that again once I release the sync upload logic to catch any that may have been missed in the interim. |
This allows us to fail the build if we can't upload to cloudfiles. We are moving towards the blobstore being the canonical repo, so want to make sure we write to it successfully before returning success to the user. This removes the async process for uploading the artifacts, and removes durable-queue from the dependencies since that was the only functionality that was using it. This is related to [#707]
I've rolled out the fix that should prevent this in the future (as part of Clojars 77), so I'm closing this. |
See:
http://repo.clojars.org/ivarref/datomic-schema/
https://clojars.org/repo/ivarref/datomic-schema/
Specifically versions
0.1.4
and0.1.4-SNAPSHOT
appear to be missing from the CDN distribution.The text was updated successfully, but these errors were encountered: