Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

nrepl-doc does not work with Clojure 1.5.0 #292

Closed
Raynes opened this Issue · 11 comments

9 participants

@Raynes

In Clojure 1.5.0 you have to explicitly require clojure.repl. You can't just refer to it magically. This breaks nrepl-doc until you actually require it yourself in the repl. I was going to try to fix it myself, but I couldn't figure out where to even put such a thing.

@hugoduncan
Owner

This should be requiring clojure.repl https://github.com/kingtim/nrepl.el/blob/master/nrepl.el#L2747

Are there other symbols it should be referring?

@Raynes

I just pulled the latest to make sure that I didn't just have something old. It still can't find clojure.repl. I have to require it first for C-c C-d to work with 1.5.0

@jamieorc

Thanks for this ticket. I'm having the same problem. Confirming that (require 'clojure.repl) in the repl gets it working.

@deg
deg commented

Actually (hat-tip to trptcolin on #leinengen IRC channel), better to do (apply require clojure.main/repl-requires) to get pprint and friends too.

@cap10morgan

Any idea why this is broken? I'd love to help fix it. This is an extremely annoying problem.

@maruks

C-c C-d works with nrepl 0.1.7 and clojure 1.5.1

@Raynes

Not for me.

@pbuckley

I tried this with nrepl 0.1.8-preview and clojure 1.5.1:
C-c M-j
C-c C-k
C-c C-d works for things like "contains?"

but I get this error in my minibuffer when I try C-c C-d on clojure.string/replace (which I'm not explicitly requiring):
wrong type argument wholenump, -85

I tried deg's suggestion of (apply require clojure.main/repl-requires) in the nrepl buffer and only once (somehow) got C-c C-d to work with clojure.string/replace. I've tried a few variations of the following with no success:

C-c M-j
C-c C-k
C-c C-d clojure.string/replace

C-c M-j
C-c C-k
switch to nrepl and (apply require clojure.main/repl-requires)
C-c C-d clojure.string/replace

C-c M-j
switch to nrepl and (apply require clojure.main/repl-requires)
C-c C-k
C-c C-d clojure.string/replace

@skelter

Is this thought to be still broken or working?

@bbatsov
Owner

Still broken.

@bbatsov bbatsov closed this in 0a30655
@bbatsov
Owner

While I could not reproduce the issue, I've updated the requires used in the tooling session. Hopefully this would resolve your problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.