cider-jump-to-def should use a 'var-info' op if present. #462

Closed
gtrak opened this Issue Jan 25, 2014 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

gtrak commented Jan 25, 2014

Much like nrepl-complete [#460], we need an op and nrepl middleware to remove the reliance on 'eval' for cljs support.

Current code builds a huge string:
https://github.com/clojure-emacs/cider/blob/master/cider-interaction.el#L492

I am happy to work on such a middleware. If needed, I can try to implement the elisp op call and eval fallback.

var-info will take an ns and var name and return file+line, doc, arglists and whatever else is in common between clj and cljs.

Owner

bbatsov commented Jan 25, 2014

Indeed. Such a middleware should also be part of cider-nrepl. My long term plan is to remove all non-trivial & non-portable inlined code and to replace it with nREPL middleware.

@gtrak gtrak added a commit to gtrak/cider that referenced this issue Jan 31, 2014

@gtrak gtrak re #462 - jump-to-def via 'info' op 399d343

@bbatsov bbatsov added a commit that referenced this issue Feb 7, 2014

@bbatsov bbatsov Merge pull request #465 from gtrak/master
re #462 - jump-to-def via 'info' op
56dc504

bbatsov closed this Feb 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment