Treat , as a non-logical sexpr character

[arrdem]

This causes clojure-forward-logical-sexp to skip over , when for
instance computing vertical alignments.

Fixes #367

[Malabarba]

Well, I guess that was easier than expected. 😄
Could also add a test for this in the alignment tests? It's very easy to write. Just copy one of the other tests in there, and replace the code string with an example that failed before but works now.

[Malabarba]

Well, I guess that was easier than expected. 😄
Could also add a test for this in the alignment tests? It's very easy to write. Just copy one of the other tests in there, and replace the code string with an example that failed before but works now.

[Malabarba]

And thanks a ton btw!

[Malabarba]

And thanks a ton btw!

[arrdem]

Yeah I'm honestly kinda surprised that this is all it took even in some fairly torturous case...

[arrdem]

Yeah I'm honestly kinda surprised that this is all it took even in some fairly torturous case...

[arrdem]

I don't think this is right however

[arrdem]

I don't think this is right however

[arrdem]

This is also pretty tortured....

[arrdem]

This is also pretty tortured....

[arrdem]

Also isn't right... not sure what's going on here.

[arrdem]

Also isn't right... not sure what's going on here.

[Malabarba]

Hmm. Now that I think about it... The current code probably assumes that non-logical sexps come before the logical sexp, which is not true for commas.
I don't think we need to change that, though (commas aren't really sexps anyway). It should be enough to just (skip-chars-forward ",") after moving over a logical sexp. This won't cover some of the more tortuous cases you tried above, but it should cover the case of a single comma after a sexp, which is really the only one I'm concerned with.

[Malabarba]

Hmm. Now that I think about it... The current code probably assumes that non-logical sexps come before the logical sexp, which is not true for commas.
I don't think we need to change that, though (commas aren't really sexps anyway). It should be enough to just (skip-chars-forward ",") after moving over a logical sexp. This won't cover some of the more tortuous cases you tried above, but it should cover the case of a single comma after a sexp, which is really the only one I'm concerned with.

[arrdem]

Okay. These two together seem to do the job better.

[arrdem]

Okay. These two together seem to do the job better.

[Malabarba]

Merged! I also added a bit of code so that clojure-align will automatically cleanup excessive commas.

[Malabarba]

Merged! I also added a bit of code so that clojure-align will automatically cleanup excessive commas.

[arrdem]

Did you test this at all for yourself? I'm concerned that it has fairly significant limitations from mucking this afternoon 😞

[arrdem]

Did you test this at all for yourself? I'm concerned that it has fairly significant limitations from mucking this afternoon 😞

[Malabarba]

I did, but I also changed the code a bit, which might have overcome the limitations. Have you tried the version on master?

[Malabarba]

I did, but I also changed the code a bit, which might have overcome the limitations. Have you tried the version on master?

[arrdem]

No I've been in hospital all day. I'll check it out tomorrow.

[arrdem]

No I've been in hospital all day. I'll check it out tomorrow.

[Malabarba]

👍 Let me know when you get a chance.

[Malabarba]

👍 Let me know when you get a chance.

[arrdem]

LGTM. Thanks Artur!

[arrdem]

LGTM. Thanks Artur!